-
Notifications
You must be signed in to change notification settings - Fork 79
Marquee State Transition Updates #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Added a fix for #755 |
|
|
||
| <TextBlock Margin="0,16,0,0" | ||
| FontWeight="Bold" | ||
| Text="This Marquee will loop while hovered and pause when not hovered." /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd invert this paradigm, so you see it moving when your mouse isn't over it, as an accessibility thing folks are probably going to want to have the text stop moving if they're trying to put their mouse on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we talked on discord, both scenarios have use-cases, maybe add to the docs where and when to use each pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I noticed the default property values: speed, behaviors/repeat behaviors, and direction are not specified in the docs here.
Improved API for starting, pausing, resuming, and stopping the Marquee animations