Skip to content

Inconsistent use of resource names #92

@mlazdans

Description

@mlazdans

Related to #82

We have defined resource names

#define LE_LINK "Firebird/InterBase link"
#define LE_PLINK "Firebird/InterBase persistent link"
#define LE_TRANS "Firebird/InterBase transaction"

Then we have defined query associated resources names here:

php-firebird/ibase_query.c

Lines 115 to 116 in ce45760

#define LE_RESULT "Firebird/InterBase result"
#define LE_QUERY "Firebird/InterBase query"

They are note used:

php-firebird/ibase_query.c

Lines 219 to 227 in ce45760

void php_ibase_query_minit(INIT_FUNC_ARGS) /* {{{ */
{
le_statement = zend_register_list_destructors_ex(_php_ibase_free_statement, NULL,
"interbase statement", module_number);
le_result = zend_register_list_destructors_ex(_php_ibase_free_result, NULL,
"interbase result", module_number);
le_query = zend_register_list_destructors_ex(php_ibase_free_query_rsrc, NULL,
"interbase query", module_number);
}

For example link resource in error messages appears as "Firebird/InterBase link" but query resource as "interbase query".

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions