refactor: convert SSH files from JavaScript to TypeScript

- Convert SSH server (src/proxy/ssh/server.js -> server.ts)
- Convert SSH CLI tool (src/cli/ssh-key.js -> ssh-key.ts)
- Add proper TypeScript types and interfaces
- Install @types/ssh2 for SSH2 library types
- Fix TypeScript compilation errors with type assertions
- Update imports to use TypeScript files
- Remove @ts-expect-error comment as no longer needed

Author: dcoric

package-lock.json

@@ -100,8 +100,9 @@
     "@types/node": "^22.18.0",
     "@types/react-dom": "^17.0.26",
     "@types/react-html-parser": "^2.0.7",
-    "@types/validator": "^13.15.2",
     "@types/sinon": "^17.0.4",
+    "@types/ssh2": "^1.15.5",
+    "@types/validator": "^13.15.2",
     "@types/yargs": "^17.0.33",
     "@typescript-eslint/eslint-plugin": "^8.41.0",
     "@typescript-eslint/parser": "^8.41.0",

package.json

@@ -1,16 +1,29 @@
 #!/usr/bin/env node
 
-const fs = require('fs');
-const path = require('path');
-const axios = require('axios');
+import * as fs from 'fs';
+import * as path from 'path';
+import axios from 'axios';
 
 const API_BASE_URL = process.env.GIT_PROXY_API_URL || 'http://localhost:3000';
 const GIT_PROXY_COOKIE_FILE = path.join(
-  process.env.HOME || process.env.USERPROFILE,
+  process.env.HOME || process.env.USERPROFILE || '',
   '.git-proxy-cookies.json',
 );
 
-async function addSSHKey(username, keyPath) {
+interface ApiErrorResponse {
+  error: string;
+}
+
+interface ErrorWithResponse {
+  response?: {
+    data: ApiErrorResponse;
+    status: number;
+  };
+  code?: string;
+  message: string;
+}
+
+async function addSSHKey(username: string, keyPath: string): Promise<void> {
   try {
     // Check for authentication
     if (!fs.existsSync(GIT_PROXY_COOKIE_FILE)) {
@@ -32,6 +45,7 @@ async function addSSHKey(username, keyPath) {
     }
 
     console.log('Making API request to:', `${API_BASE_URL}/api/v1/user/${username}/ssh-keys`);
+
     // Make the API request
     await axios.post(
       `${API_BASE_URL}/api/v1/user/${username}/ssh-keys`,
@@ -47,20 +61,22 @@ async function addSSHKey(username, keyPath) {
 
     console.log('SSH key added successfully!');
   } catch (error) {
+    const axiosError = error as ErrorWithResponse;
     console.error('Full error:', error);
-    if (error.response) {
-      console.error('Response error:', error.response.data);
-      console.error('Response status:', error.response.status);
-    } else if (error.code === 'ENOENT') {
+
+    if (axiosError.response) {
+      console.error('Response error:', axiosError.response.data);
+      console.error('Response status:', axiosError.response.status);
+    } else if (axiosError.code === 'ENOENT') {
       console.error(`Error: Could not find SSH key file at ${keyPath}`);
     } else {
-      console.error('Error:', error.message);
+      console.error('Error:', axiosError.message);
     }
     process.exit(1);
   }
 }
 
-async function removeSSHKey(username, keyPath) {
+async function removeSSHKey(username: string, keyPath: string): Promise<void> {
   try {
     // Check for authentication
     if (!fs.existsSync(GIT_PROXY_COOKIE_FILE)) {
@@ -86,12 +102,14 @@ async function removeSSHKey(username, keyPath) {
 
     console.log('SSH key removed successfully!');
   } catch (error) {
-    if (error.response) {
-      console.error('Error:', error.response.data.error);
-    } else if (error.code === 'ENOENT') {
+    const axiosError = error as ErrorWithResponse;
+
+    if (axiosError.response) {
+      console.error('Error:', axiosError.response.data.error);
+    } else if (axiosError.code === 'ENOENT') {
       console.error(`Error: Could not find SSH key file at ${keyPath}`);
     } else {
-      console.error('Error:', error.message);
+      console.error('Error:', axiosError.message);
     }
     process.exit(1);
   }
@@ -106,8 +124,8 @@ const keyPath = args[2];
 if (!command || !username || !keyPath) {
   console.log(`
 Usage:
-  Add SSH key:    node ssh-key.js add <username> <path-to-public-key>
-  Remove SSH key: node ssh-key.js remove <username> <path-to-public-key>
+  Add SSH key:    npx tsx src/cli/ssh-key.ts add <username> <path-to-public-key>
+  Remove SSH key: npx tsx src/cli/ssh-key.ts remove <username> <path-to-public-key>
   `);
   process.exit(1);
 }

src/cli/ssh-key.js renamed to src/cli/ssh-key.ts

@@ -15,7 +15,6 @@ import { addUserCanAuthorise, addUserCanPush, createRepo, getRepos } from '../db
 import { PluginLoader } from '../plugin';
 import chain from './chain';
 import { Repo } from '../db/types';
-// @ts-expect-error - SSH server is a JavaScript file
 import SSHServer from './ssh/server';
 
 const { GIT_PROXY_SERVER_PORT: proxyHttpPort, GIT_PROXY_HTTPS_SERVER_PORT: proxyHttpsPort } =