Fix compile-database target

[fingolfin]

Also fix race conditions caused by targets producing files being incorrectly marked as phony.

Follow up to #59476 (guess there is a price to pay for using Claude)

@lgoettgens that might help with the issues you are seeing in JuliaPackaging/Yggdrasil#12406

[lgoettgens]

Thanks for looking into this! I'll try this with the Yggdrasil script in the morning.

Could you please also add a backport-1.13 label?

[vtjnash]

The .PHONY is correct. Even though (or especially because) it does produce a file, it needs to be forced to re-generate it to be updated

[vtjnash]

Can you change the $@.tmp files to use mktemp -p . $@.XXXXXX instead? (here and in other places where we generate files in common to release and debug, such as base/Makefile and julia_flisp.boot)

[lgoettgens]

@lgoettgens that might help with the issues you are seeing in JuliaPackaging/Yggdrasil#12406

with this patch added, the issue happens a lot less often, but I still experience it.

[fingolfin]

@vtjnash ah, I see. OK, calling a target $(BUILDDIR)/compile_commands.json that produces a file $(BUILDDIR)/compile_commands.json but is actually meant to be phony is an antipattern. But OK, we can just merge them into their compile-database "parent" targets. And add a comment as to why they are

I note that on my MacBook Pro M1 Max, the build system takes a full 2 seconds to rebuild these compile databases which I don't even use :-/.

A better fix would be to make it non-PHONY by properly tracking the dependencies; as far as as I can tell, that means tracking the content of CLANG_TOOLING_C_FLAGS, CLANG_TOOLING_CXX_FLAGS, SRCS and a couple other Make variables. But that'll take longer so I'll try a simpler solution.

@lgoettgens for you the much simpler fix should be to apply this patch:

diff --git a/src/Makefile b/src/Makefile
index 18e9a4a639..f92cd73a10 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -259,7 +259,7 @@ endif
 default: $(JULIA_BUILD_MODE) # contains either "debug" or "release"
 all: debug release
 
-release debug: %: libjulia-internal-% libjulia-codegen-% $(BUILDDIR)/compile_commands.json
+release debug: %: libjulia-internal-% libjulia-codegen-%
 
 $(BUILDDIR):
 	mkdir -p $(BUILDDIR)
diff --git a/src/flisp/Makefile b/src/flisp/Makefile
index 135859eacb..98b336fb14 100644
--- a/src/flisp/Makefile
+++ b/src/flisp/Makefile
@@ -61,9 +61,9 @@ DEBUGFLAGS_COMMON += $(FLAGS_COMMON)
 
 default: release
 
-release: $(BUILDDIR)/$(EXENAME)$(EXE) $(BUILDDIR)/compile_commands.json
+release: $(BUILDDIR)/$(EXENAME)$(EXE)
 
-debug: $(BUILDDIR)/$(EXENAME)-debug$(EXE) $(BUILDDIR)/compile_commands.json
+debug: $(BUILDDIR)/$(EXENAME)-debug$(EXE)
 
 $(BUILDDIR):
 	mkdir -p $(BUILDDIR)
diff --git a/src/support/Makefile b/src/support/Makefile
index 2b48a20bbc..3c1dba17f8 100644
--- a/src/support/Makefile
+++ b/src/support/Makefile
@@ -53,8 +53,8 @@ $(BUILDDIR)/host/Makefile:
 	@printf "%s\n" 'BUILDING_HOST_TOOLS=1' >> $@
 	@printf "%s\n" 'include $(SRCDIR)/Makefile' >> $@
 
-release: $(BUILDDIR)/libsupport.a $(BUILDDIR)/compile_commands.json
-debug: $(BUILDDIR)/libsupport-debug.a $(BUILDDIR)/compile_commands.json
+release: $(BUILDDIR)/libsupport.a
+debug: $(BUILDDIR)/libsupport-debug.a
 
 $(BUILDDIR)/libsupport.a: $(OBJS) | $(BUILDIR)
 	rm -rf $@

[fingolfin]

updated

[lgoettgens]

Could someone please add a backport 1.13 label?