FIX telemetry is not disabled by default

Author: sumneko

changelog.md

@@ -1,6 +1,7 @@
 # changelog
 
 ## 2.6.5
+* `FIX` telemetry is not disabled by default
 * `FIX` [#934](https://github.com/sumneko/lua-language-server/issues/934)
 * `FIX` [#952](https://github.com/sumneko/lua-language-server/issues/952)
 

script/client.lua

@@ -197,7 +197,7 @@ end
 ---@field prop?     string
 ---@field value     any
 ---@field action    '"add"'|'"set"'|'"prop"'
----@field isGlobal? boolean
+---@field global?   boolean
 ---@field uri?      uri
 
 ---@param cfg table
@@ -298,7 +298,7 @@ local function tryModifyClientGlobal(finalChanges)
     local changes = {}
     for i = #finalChanges, 1, -1 do
         local change = finalChanges[i]
-        if change.isGlobal then
+        if change.global then
             changes[#changes+1] = change
             finalChanges[i] = finalChanges[#finalChanges]
             finalChanges[#finalChanges] = nil

script/config/config.lua

@@ -212,7 +212,7 @@ local Template = {
     ['Lua.IntelliSense.traceReturn']        = Type.Boolean >> false,
     ['Lua.IntelliSense.traceBeSetted']      = Type.Boolean >> false,
     ['Lua.IntelliSense.traceFieldInject']   = Type.Boolean >> false,
-    ['Lua.telemetry.enable']                = Type.Or(Type.Boolean >> false, Type.Nil),
+    ['Lua.telemetry.enable']                = Type.Or(Type.Boolean >> false, Type.Nil) >> nil,
     ['files.associations']                  = Type.Hash(Type.String, Type.String),
     ['files.exclude']                       = Type.Hash(Type.String, Type.Boolean),
     ['editor.semanticHighlighting.enabled'] = Type.Or(Type.Boolean, Type.String),

script/service/telemetry.lua

@@ -78,7 +78,7 @@ local isValid  = false
 
 timer.wait(5, function ()
     timer.loop(300, function ()
-        if not isValid then
+        if isValid ~= true then
             return
         end
         local suc, link = pcall(net.connect, 'tcp', 'moe-moe.love', 11577)
@@ -97,7 +97,7 @@ timer.wait(5, function ()
         end
     end)()
     timer.loop(1, function ()
-        if not isValid then
+        if isValid ~= true then
             return
         end
         net.update()
@@ -107,7 +107,9 @@ end)
 local m = {}
 
 function m.updateConfig()
-    isValid = config.get(nil, 'Lua.telemetry.enable')
+    local enable = config.get(nil, 'Lua.telemetry.enable')
+    assert(enable == true or enable == false or enable == nil)
+    isValid = enable
     if isValid == false then
         return
     end