renaming ShouldGenerateAlias to create CreateAlias

Author: Razmo99

src/PowerShellEditorServices/Services/PowerShell/Handlers/RenameSymbol.cs

@@ -17,7 +17,7 @@ namespace Microsoft.PowerShell.EditorServices.Handlers
     internal interface IRenameSymbolHandler : IJsonRpcRequestHandler<RenameSymbolParams, RenameSymbolResult> { }
 
     public class RenameSymbolOptions {
-        public bool ShouldGenerateAlias { get; set; }
+        public bool CreateAlias { get; set; }
     }
 
     public class RenameSymbolParams : IRequest<RenameSymbolResult>

src/PowerShellEditorServices/Services/PowerShell/Refactoring/IterativeVariableVisitor.cs

@@ -31,7 +31,7 @@ public IterativeVariableRename(string NewName, int StartLineNumber, int StartCol
             this.StartLineNumber = StartLineNumber;
             this.StartColumnNumber = StartColumnNumber;
             this.ScriptAst = ScriptAst;
-            this.options = options ?? new RenameSymbolOptions { ShouldGenerateAlias = true };
+            this.options = options ?? new RenameSymbolOptions { CreateAlias = true };
 
             VariableExpressionAst Node = (VariableExpressionAst)GetVariableTopAssignment(StartLineNumber, StartColumnNumber, ScriptAst);
             if (Node != null)
@@ -406,7 +406,7 @@ private void ProcessVariableExpressionAst(VariableExpressionAst variableExpressi
                     };
                     // If the variables parent is a parameterAst Add a modification
                     if (variableExpressionAst.Parent is ParameterAst paramAst && !AliasSet &&
-                        options.ShouldGenerateAlias)
+                        options.CreateAlias)
                     {
                         TextChange aliasChange = NewParameterAliasChange(variableExpressionAst, paramAst);
                         Modifications.Add(aliasChange);