From eb076b5cfab7da09ba5686475918bd8159a5c841 Mon Sep 17 00:00:00 2001 From: "nia.mccash" Date: Mon, 30 Sep 2024 07:33:26 -0700 Subject: [PATCH 1/3] Added table check for item_option_new table --- ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt | 2 +- ...check_cf9d1010c34916908dbc32f1b4013184.xml | 42 +++++++++++++++++++ 2 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cf9d1010c34916908dbc32f1b4013184.xml diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt index 8d1f820..3dc5a7f 100644 --- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt @@ -1 +1 @@ -zKXVYjmTYdaUi17DjcgoXWtXX_r6CHPBtrSKlLiqj8Eq7u0uljxaXTgwGGgfBb0bZPqDwv3KpiZ5TBgbcB174pIXaw35AnbNe5iXTbargQQgyhTbcg6_oynarqVoW0VaTfI3XajNJZN2mF889Yz-Mcz5YRB7hK80971bWOcMDhb2QnLAXf7U98k4apomHB45owe2g5XuAoqk4zLwGwgV5sl2wcFfhClAfzuL7jhaxwvd37aEx4BCqjLpkKLRcYT5twtMoJbKAJUAz4ry9UwcbCuSK2GS03-2rsSjeNVqh3NBWNFbtBo3I22SJwVEIpg2PQCHYb5f2ztmHLWknivKaVCzE5A1n6VhVKdST14FKs-F6vtsffOko_MgzgN_by3L0mNy8PcWM9S18_B4pLn9wyREtG3i0UIBOXbpmlCWPXKCwEN7CNYYef09UcCgawGqVRPusHj0O7J7tCbs4241UyfS7om4ch3QD2qMro-TlQjdna_S-5ApnBg8rIb8HapfWJOhGril_TMmtYROGcK3suw1kZuJUEiG5NrhH8e0AM1fXAdF6Aed7z0kEH8UF308F_-SqJs5g3dlRa6uAcmZccZsGCCK4-CEWRtpct38F3ly5i1fPkrb9keSSAJ6-ojhemXulA2jWe1eu5I66bGsPbeMIW807BK4B7h2jOLnYXw \ No newline at end of file +CuNEYHj5RbBsjVJxohTMD1xntLLtuzW06YrIQxv_dnuv66Z-CP9Yyz94aT1y6VMee62ueoZ-zoVm79qzmSN0EDnNTIajGUE-L9E8z-wSmPjpDRK6unp5pT-WyQru961HXU1NDT6tYoVYpmHPnC1pxK1hGqlJ5xCFlFjoYHaWTOMQ-jgr2lppwmOLGMGR7znGbC3ffVubbJzVWxZF2A54U5qoSwKmMb-Sl6nBVJvbZz8finGJvOBn8WzxH6DP_rUNqXJ4ZflVbC2EWzi2mlf_jhEvu35jXElgy6I7myTSoOJvWiK8J6arVkKEt1MNTtewGnDrFnAbFFZ53T08x7UafmirFgZuS4MbzwCYGQ_dX9IlcB-5OLXuB1JYApTLKEJnT364IFKOpAgwzZm5F9dhRAYQG6qVRonDCHrXl1ZJ1WFEMgDCksXtQpTcc53Fe-cH348-sbttOrFExqMtN8HmrJxdjJWFQB0WIPnb7BLMIc6qvc0QIfku9KZpHSlse1cttB-pn_l5UM07YLgjoWCB2wvGaLkZdjDOT0MZizytu7SaAs0SFgm4Q2g4p3xTJ9C78cM24TaT0oQ_gIehRDaf-ETeb4XCdMj1hpaRB4PR2JquoRXJvkfZ7bB6l0ahyfDeQvKqk2cmDf0Mt2CKXeALoAOwe3vhtLMTXKOL1NBAjm4 \ No newline at end of file diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cf9d1010c34916908dbc32f1b4013184.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cf9d1010c34916908dbc32f1b4013184.xml new file mode 100644 index 0000000..9ef7afe --- /dev/null +++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cf9d1010c34916908dbc32f1b4013184.xml @@ -0,0 +1,42 @@ + + + true + false + upgradability + type=8^reference=sys_choice^EQ + + + + The Choice table should not be used as the reference table for a Reference type field. Reference fields store the sys_id of the corresponding record in the reference table and show the specified display value. For example: the caller_id field stores the sys_id of a record from the user table and displays the corresponding name value. This presents a problem when using the sys_choice table, because existing records are deleted and replaced when choices are modified. This causes a new sys_id to be generated for each record in the choice list. So the sys_id stored in the Reference field is no longer a valid value and the reference is broken. + https://support.servicenow.com/kb?id=kb_article_view&sysparm_article=KB0813643 + scan_finding + Do not reference sys_choice table + 3 + + + 100 + 0 + 1 + + Do not reference sys_choice table + scan_table_check + nia.mccash + 2024-09-30 14:30:45 + cf9d1010c34916908dbc32f1b4013184 + 0 + Do not reference sys_choice table + ca8467c41b9abc10ce0f62c3b24bcbaa + + ca8467c41b9abc10ce0f62c3b24bcbaa + scan_table_check_cf9d1010c34916908dbc32f1b4013184 + nia.mccash + 2024-09-30 14:30:45 + item_option_new
+ false + + + From 7d299f2cf56ad6dadec291609cd320363b7f337a Mon Sep 17 00:00:00 2001 From: niamccash <39105458+niamccash@users.noreply.github.com> Date: Mon, 30 Sep 2024 10:38:43 -0400 Subject: [PATCH 2/3] Update README.md with Do not reference sys_choice table desc --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index afe7c51..fc32291 100644 --- a/README.md +++ b/README.md @@ -229,6 +229,9 @@ Restrict the number of row counts ma x to 10,20,50 instead of higher limits such Navigate to the user preference table and search by 'rowcount'. Set the value to 50 max. Also, can set the property 'glide.ui.per_page' sys property value to 10, 20, 50 only +### Do not reference sys_choice table +The Choice table should not be used as the reference table for a Reference type field. Reference fields store the sys_id of the corresponding record in the reference table and show the specified display value. For example: the caller_id field stores the sys_id of a record from the user table and displays the corresponding name value. This presents a problem when using the sys_choice table, because existing records are deleted and replaced when choices are modified. This causes a new sys_id to be generated for each record in the choice list. So the sys_id stored in the Reference field is no longer a valid value and the reference is broken. + ## Category: Security ##Check Mandatory fields on incident From 6724ef22bbc2e31eb6c4ef90f547e5732b1624c7 Mon Sep 17 00:00:00 2001 From: niamccash <39105458+niamccash@users.noreply.github.com> Date: Mon, 30 Sep 2024 10:39:35 -0400 Subject: [PATCH 3/3] Corrected category for Do not reference sys_choice table desc --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index fc32291..20bf8a0 100644 --- a/README.md +++ b/README.md @@ -161,6 +161,9 @@ Check if the Choice [sys_choice] table has been extended. This is not supported ### User table should not be extended Check if the User [sys_user] table has been extended. This is not recommended and can cause problems when a user needs to be in more than one user table. +### Do not reference sys_choice table +The Choice table should not be used as the reference table for a Reference type field. Reference fields store the sys_id of the corresponding record in the reference table and show the specified display value. For example: the caller_id field stores the sys_id of a record from the user table and displays the corresponding name value. This presents a problem when using the sys_choice table, because existing records are deleted and replaced when choices are modified. This causes a new sys_id to be generated for each record in the choice list. So the sys_id stored in the Reference field is no longer a valid value and the reference is broken. + ## Category: Performance ### getMessage() called in Client Script @@ -229,9 +232,6 @@ Restrict the number of row counts ma x to 10,20,50 instead of higher limits such Navigate to the user preference table and search by 'rowcount'. Set the value to 50 max. Also, can set the property 'glide.ui.per_page' sys property value to 10, 20, 50 only -### Do not reference sys_choice table -The Choice table should not be used as the reference table for a Reference type field. Reference fields store the sys_id of the corresponding record in the reference table and show the specified display value. For example: the caller_id field stores the sys_id of a record from the user table and displays the corresponding name value. This presents a problem when using the sys_choice table, because existing records are deleted and replaced when choices are modified. This causes a new sys_id to be generated for each record in the choice list. So the sys_id stored in the Reference field is no longer a valid value and the reference is broken. - ## Category: Security ##Check Mandatory fields on incident