Skip to content

Conversation

@AGMASO
Copy link
Collaborator

@AGMASO AGMASO commented Oct 27, 2025

General Changes

  • Added logic to automatically send the user's wallet address when submitting an inquiry, if analytics opt-in is enabled. Otherwise, a checkbox is displayed allowing the user to choose whether to share their wallet address for better support.

  • Added a new Amplitude track event triggered when the user submits the form.

Developer Notes

  • Check it out the PLAIN_API_KEY still there and correct in prod
  • Do we need anything else in the trackEvent params?
Screenshot 2025-10-27 at 12 33 25

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
interface Ready Ready Preview Comment Oct 27, 2025 11:35am

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Comment on lines +75 to +82
if (walletAddress && typeof walletAddress === 'string') {
const candidate = walletAddress.trim();
if (ethers.utils.isAddress(candidate)) {
sanitizedWalletAddress = ethers.utils.getAddress(candidate);
} else {
console.warn('Invalid walletAddress format provided');
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment on lines +47 to +48
typeof window !== 'undefined' ? localStorage.getItem(CONSENT_KEY) === 'true' : false;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be safer to get this from root store, check analyticsSlice for some variable in there

SWITCH_TYPE: 'Change switch type',
};
export const SUPPORT = {
TICKET_CREATED: 'Support Ticket Created', // Este string es lo que ve Amplitude
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spanish lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants