-
Notifications
You must be signed in to change notification settings - Fork 454
feat: send rich info to Plain support and track submit event for amplitude #2734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
| if (walletAddress && typeof walletAddress === 'string') { | ||
| const candidate = walletAddress.trim(); | ||
| if (ethers.utils.isAddress(candidate)) { | ||
| sanitizedWalletAddress = ethers.utils.getAddress(candidate); | ||
| } else { | ||
| console.warn('Invalid walletAddress format provided'); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
| typeof window !== 'undefined' ? localStorage.getItem(CONSENT_KEY) === 'true' : false; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be safer to get this from root store, check analyticsSlice for some variable in there
| SWITCH_TYPE: 'Change switch type', | ||
| }; | ||
| export const SUPPORT = { | ||
| TICKET_CREATED: 'Support Ticket Created', // Este string es lo que ve Amplitude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spanish lol
General Changes
Added logic to automatically send the user's wallet address when submitting an inquiry, if analytics opt-in is enabled. Otherwise, a checkbox is displayed allowing the user to choose whether to share their wallet address for better support.
Added a new Amplitude track event triggered when the user submits the form.
Developer Notes
PLAIN_API_KEYstill there and correct in prodReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files