iOS 12 Compatibility?

[markturnip]

It appears there's a few issues with iOS 12.

One of which being a crash which may be related to #77.
Also some trouble with headers especially when pinning to bounds.
I can provide more details here, however should this library have support for iOS12?

[bryankeller]

Hi @markturnip - MagazineLayout should definitely support iOS 12. Can you post an example of the issues / crashes you're seeing?

[smurphy]

@markturnip I was seeing the same errors when using UICollectionView.elementKindSectionHeader kind instead of MagazineLayout.SupplementaryViewKind.sectionHeader. Is it possible that's what you experienced?

[markst]

@smurphy Not too sure afraid. Haven't got the time to investigate fully. I'm checking for both header kinds, so I don't think I'm sharing the same issue. Thanks but.

if [MagazineLayout.SupplementaryViewKind.sectionHeader, UICollectionView.elementKindSectionHeader].contains(kind) {
  let header = view.dequeueReusableSupplementaryView(
    ofKind: UICollectionView.elementKindSectionHeader,
    withReuseIdentifier: ScheduleHeaderView.identifier,
    for: indexPath) as! ScheduleHeaderView
  return header

Thread 1: Exception: "*** -[__NSDictionaryM setObject:forKey:]: object cannot be nil (key: <_UICollectionViewItemKey: 0x600000448910> Type = DV ReuseID = (null) IndexPath = (null))"

[markst]

My header frame just resolves to zero rect every time in iOS 11.0.1:

Could perhaps be something to do with implicit layout height being added:

    "<NSLayoutConstraint:0x600000282260 'UIView-Encapsulated-Layout-Height' XXXX.ScheduleHeaderView:0x7f9df5452d60.height == 0   (active)>"
)

Edit:

Or rather it looks like it's due to having used Storyboards, as all my headers are defined as UICollectionView.elementKindSectionHeader. Can't seem to redefine that, so I'd have to pull all my headers out into their own xib's and register with the appropriate header kind.

[markst]

Alright confirmed that it's due to having defined my headers & footers in storyboards.

I'm reluctant to do so for my entire project as I do prefer to work entirely in storyboards.

However perhaps it's my only option without being able to define custom element kind's in storyboard.