Skip to content
This repository was archived by the owner on Mar 14, 2025. It is now read-only.
This repository was archived by the owner on Mar 14, 2025. It is now read-only.

useLoading is not consistent with other plugins #106

@IGx89

Description

@IGx89

Hello! First off, thanks a lot for this useful plugin :). Wanted to bring your attention to a behavior difference in your useLoading implementation vs. other plugins (such as vue-router's useRouter). Your useLoading methods creates a brand new instance, separate from what was globally installed, while other plugins simply call inject to get the global instance (example). That means if I want to use the global instance, with all the configuration options I set, I have to do this instead:

const loading = inject("$loading") as PluginApi;

I'd recommend changing it to just be a wrapper around inject, preventing duplicate instances and avoiding confusing situations such as what I ran into, where global configs strangely didn't have any effect.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions