-
Couldn't load subscription status.
- Fork 352
Description
Issue workflow progress
Progress of the issue based on the
Contributor Workflow
- 1. The issue provides a reproduction available on
Github,
Stackblitz
or
CodeSandbox
Make sure to fork this template and run
yarn generatein the terminal.Please make sure Mesh package versions under
package.jsonmatches yours.
- 2. A failing test has been provided
- 3. A local solution has been provided
- 4. A pull request is pending review
Describe the bug
There is no way to pass a deepObject with a GET-parameter format that PHP recognizes.
loadOpenAPISubgraph takes a queryStringOptions object but that is ignored in loaders/json-schema addExecutionDirectivesToComposer by falling back to undefined when no operation-specific option has been provided:
queryStringOptions:
'queryStringOptions' in operationConfig
? operationConfig.queryStringOptions
: undefined,
Instead we should fallback to the queryStringOptions that is passed in:
queryStringOptions:
'queryStringOptions' in operationConfig
? operationConfig.queryStringOptions
: queryStringOptions,
To Reproduce Steps to reproduce the behavior:
This config does not change the behaviour:
export const composeConfig = defineComposeConfig({
output: 'supergraph.ts',
subgraphs: [
{
sourceHandler: loadOpenAPISubgraph('User', {
...
queryStringOptions : { arrayFormat: 'brackets' }
})
},
Expected behavior
Config should be respected
Environment:
Additional context
Fix:
packages/loaders/json-schema/src/addExecutionLogicToComposer.ts