Seeding data with multiple items causes stack overflow

[punkouter2021]

Using the pattern here I am trying to seed an ibject that contains another collection... Details here.. Any help is grat.. Meanwhile Ill try removing all the EntityBase stuff to see if thats the problem.

https://stackoverflow.com/questions/58595744/why-does-adding-more-than-1-item-to-this-collection-in-efcore-cause-a-stack-over

[mehmetozkaya]

Thank you for your report. Let me see what is the error and how we can manage it. During this time if you solved that could you please send me your pull request over github ?

[Ungerfall]

The issue is that there is a recursive infinite call

if (item.IsTransient() || IsTransient())
    return false;
else
    return item == this;

which calls

public static bool operator ==(EntityBase<TId> left, EntityBase<TId> right)
{
    if (Equals(left, null))
        return Equals(right, null) ? true : false;
    else
        return left.Equals(right);
}

The correct implementation would be

public override bool Equals(object? obj)
{
    if (obj is null)
    {
        return false;
    }

    if (ReferenceEquals(this, obj))
    {
        return true;
    }

    if (GetType() != obj.GetType())
    {
        return false;
    }

    if (obj is not EntityBase<TId> entity)
    {
        return false;
    }

    return Id.Equals(entity.Id); // requires IEquatable<TId> generic constraint
}
public static bool operator ==(EntityBase<TId> left, EntityBase<TId> right)
{
    return left is not null && right is not null && left.Equals(right);
}