This repository was archived by the owner on Aug 8, 2020. It is now read-only.
Add a symbol property to get current option chain's option #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I missed this as I was not subscribed to this repo. I don't think the symbol should be exposed. Instead expose a method that gets the options. It also needs to be documented in the readme. |
sindresorhus
reviewed
Jan 6, 2020
| @@ -1,4 +1,6 @@ | |||
| 'use strict'; | |||
| const optsSymbol = Symbol('option-chain-opts'); | |||
There was a problem hiding this comment.
Suggested change
| const optsSymbol = Symbol('option-chain-opts'); | |
| const optionsSymbol = Symbol('optionChainOptions'); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3