From bedfd9d4ca900b6b05657dcf1f3aef01fd9c627a Mon Sep 17 00:00:00 2001 From: Garrett Beatty Date: Wed, 29 Oct 2025 17:44:14 -0400 Subject: [PATCH] Remove AmazonWebServiceResponse as base class for transfer utility repsonse objects. stack-info: PR: https://github.com/aws/aws-sdk-net/pull/4087, branch: GarrettBeatty/stacked/12 --- .../c49077d9-90b3-437f-b316-6d8d8833ae75.json | 11 +++++++++++ .../Custom/Transfer/Internal/ResponseMapper.cs | 16 ---------------- .../Transfer/TransferUtilityDownloadResponse.cs | 2 +- .../Transfer/TransferUtilityUploadResponse.cs | 2 +- .../S3/UnitTests/Custom/ResponseMapperTests.cs | 13 +++++-------- 5 files changed, 18 insertions(+), 26 deletions(-) create mode 100644 generator/.DevConfigs/c49077d9-90b3-437f-b316-6d8d8833ae75.json diff --git a/generator/.DevConfigs/c49077d9-90b3-437f-b316-6d8d8833ae75.json b/generator/.DevConfigs/c49077d9-90b3-437f-b316-6d8d8833ae75.json new file mode 100644 index 000000000000..999c11e35b3e --- /dev/null +++ b/generator/.DevConfigs/c49077d9-90b3-437f-b316-6d8d8833ae75.json @@ -0,0 +1,11 @@ +{ + "services": [ + { + "serviceName": "S3", + "type": "patch", + "changeLogMessages": [ + "Remove AmazonWebServiceResponse as base class for transfer utility repsonse objects." + ] + } + ] +} diff --git a/sdk/src/Services/S3/Custom/Transfer/Internal/ResponseMapper.cs b/sdk/src/Services/S3/Custom/Transfer/Internal/ResponseMapper.cs index 302ffd5e2fce..0eb055d6db1b 100644 --- a/sdk/src/Services/S3/Custom/Transfer/Internal/ResponseMapper.cs +++ b/sdk/src/Services/S3/Custom/Transfer/Internal/ResponseMapper.cs @@ -63,11 +63,6 @@ internal static TransferUtilityUploadResponse MapPutObjectResponse(PutObjectResp response.VersionId = source.VersionId; response.Size = source.Size; - // Copy response metadata - response.ResponseMetadata = source.ResponseMetadata; - response.ContentLength = source.ContentLength; - response.HttpStatusCode = source.HttpStatusCode; - return response; } @@ -102,11 +97,6 @@ internal static TransferUtilityUploadResponse MapCompleteMultipartUploadResponse response.Key = source.Key; response.Location = source.Location; - // Copy response metadata - response.ResponseMetadata = source.ResponseMetadata; - response.ContentLength = source.ContentLength; - response.HttpStatusCode = source.HttpStatusCode; - return response; } @@ -157,12 +147,6 @@ internal static TransferUtilityDownloadResponse MapGetObjectResponse(GetObjectRe response.TagCount = source.TagCount; response.VersionId = source.VersionId; response.WebsiteRedirectLocation = source.WebsiteRedirectLocation; - - // Copy response metadata - response.ResponseMetadata = source.ResponseMetadata; - response.ContentLength = source.ContentLength; - response.HttpStatusCode = source.HttpStatusCode; - return response; } diff --git a/sdk/src/Services/S3/Custom/Transfer/TransferUtilityDownloadResponse.cs b/sdk/src/Services/S3/Custom/Transfer/TransferUtilityDownloadResponse.cs index d10c72f47c0f..761bb1454146 100644 --- a/sdk/src/Services/S3/Custom/Transfer/TransferUtilityDownloadResponse.cs +++ b/sdk/src/Services/S3/Custom/Transfer/TransferUtilityDownloadResponse.cs @@ -31,7 +31,7 @@ namespace Amazon.S3.Transfer /// Response object for Transfer Utility download operations. /// Contains response metadata from download operations. /// - public class TransferUtilityDownloadResponse : AmazonWebServiceResponse + public class TransferUtilityDownloadResponse { /// /// Gets and sets the AcceptRanges property. diff --git a/sdk/src/Services/S3/Custom/Transfer/TransferUtilityUploadResponse.cs b/sdk/src/Services/S3/Custom/Transfer/TransferUtilityUploadResponse.cs index fc3218f0411e..e7361bfd629f 100644 --- a/sdk/src/Services/S3/Custom/Transfer/TransferUtilityUploadResponse.cs +++ b/sdk/src/Services/S3/Custom/Transfer/TransferUtilityUploadResponse.cs @@ -32,7 +32,7 @@ namespace Amazon.S3.Transfer /// Contains unified response fields from both simple uploads (PutObjectResponse) /// and multipart uploads (CompleteMultipartUploadResponse). /// - public class TransferUtilityUploadResponse : AmazonWebServiceResponse + public class TransferUtilityUploadResponse { private bool? _bucketKeyEnabled; private string _bucketName; diff --git a/sdk/test/Services/S3/UnitTests/Custom/ResponseMapperTests.cs b/sdk/test/Services/S3/UnitTests/Custom/ResponseMapperTests.cs index 5b19acae5b76..32310545fb27 100644 --- a/sdk/test/Services/S3/UnitTests/Custom/ResponseMapperTests.cs +++ b/sdk/test/Services/S3/UnitTests/Custom/ResponseMapperTests.cs @@ -149,8 +149,7 @@ public void MapPutObjectResponse_AllMappedProperties_WorkCorrectly() }, (sourceResponse, targetResponse) => { - Assert.AreEqual(sourceResponse.HttpStatusCode, targetResponse.HttpStatusCode, "HttpStatusCode should match"); - Assert.AreEqual(sourceResponse.ContentLength, targetResponse.ContentLength, "ContentLength should match"); + }); } @@ -644,12 +643,11 @@ public void MapCompleteMultipartUploadResponse_AllMappedProperties_WorkCorrectly (sourceResponse) => { sourceResponse.HttpStatusCode = HttpStatusCode.OK; - sourceResponse.ContentLength = 2048; + sourceResponse.ContentLength = 1024; }, (sourceResponse, targetResponse) => { - Assert.AreEqual(sourceResponse.HttpStatusCode, targetResponse.HttpStatusCode, "HttpStatusCode should match"); - Assert.AreEqual(sourceResponse.ContentLength, targetResponse.ContentLength, "ContentLength should match"); + }); } @@ -720,12 +718,11 @@ public void MapGetObjectResponse_AllMappedProperties_WorkCorrectly() (sourceResponse) => { sourceResponse.HttpStatusCode = HttpStatusCode.OK; - sourceResponse.ContentLength = 2048; + sourceResponse.ContentLength = 1024; }, (sourceResponse, targetResponse) => { - Assert.AreEqual(sourceResponse.HttpStatusCode, targetResponse.HttpStatusCode, "HttpStatusCode should match"); - Assert.AreEqual(sourceResponse.ContentLength, targetResponse.ContentLength, "ContentLength should match"); + }); }