Merge pull request #87 from codeclimate/abh-increase-mass-visibility

Include mass in issue description

Author: Ashley Baldwin-Hunter

lib/cc/engine/analyzers/violation.rb

@@ -93,6 +93,7 @@ def fingerprint
         def description
           description = "#{check_name} found in #{occurrences} other location"
           description += "s" if occurrences > 1
+          description += " (mass = #{mass})"
           description
         end
 

spec/cc/engine/analyzers/javascript/main_spec.rb

@@ -22,7 +22,7 @@
 
       expect(json["type"]).to eq("issue")
       expect(json["check_name"]).to eq("Identical code")
-      expect(json["description"]).to eq("Identical code found in 2 other locations")
+      expect(json["description"]).to eq("Identical code found in 2 other locations (mass = 11)")
       expect(json["categories"]).to eq(["Duplication"])
       expect(json["location"]).to eq({
         "path" => "foo.js",
@@ -50,7 +50,7 @@
 
       expect(json["type"]).to eq("issue")
       expect(json["check_name"]).to eq("Similar code")
-      expect(json["description"]).to eq("Similar code found in 2 other locations")
+      expect(json["description"]).to eq("Similar code found in 2 other locations (mass = 11)")
       expect(json["categories"]).to eq(["Duplication"])
       expect(json["location"]).to eq({
         "path" => "foo.js",

spec/cc/engine/analyzers/php/main_spec.rb

@@ -35,7 +35,7 @@
 
       expect(json["type"]).to eq("issue")
       expect(json["check_name"]).to eq("Identical code")
-      expect(json["description"]).to eq("Identical code found in 1 other location")
+      expect(json["description"]).to eq("Identical code found in 1 other location (mass = 11)")
       expect(json["categories"]).to eq(["Duplication"])
       expect(json["location"]).to eq({
         "path" => "foo.php",

spec/cc/engine/analyzers/python/main_spec.rb

@@ -22,7 +22,7 @@
 
       expect(json["type"]).to eq("issue")
       expect(json["check_name"]).to eq("Identical code")
-      expect(json["description"]).to eq("Identical code found in 2 other locations")
+      expect(json["description"]).to eq("Identical code found in 2 other locations (mass = 6)")
       expect(json["categories"]).to eq(["Duplication"])
       expect(json["location"]).to eq({
         "path" => "foo.py",
@@ -50,7 +50,7 @@
 
       expect(json["type"]).to eq("issue")
       expect(json["check_name"]).to eq("Similar code")
-      expect(json["description"]).to eq("Similar code found in 2 other locations")
+      expect(json["description"]).to eq("Similar code found in 2 other locations (mass = 6)")
       expect(json["categories"]).to eq(["Duplication"])
       expect(json["location"]).to eq({
         "path" => "foo.py",

spec/cc/engine/analyzers/ruby/main_spec.rb

@@ -34,7 +34,7 @@ module CC::Engine::Analyzers
 
         expect(json["type"]).to eq("issue")
         expect(json["check_name"]).to eq("Similar code")
-        expect(json["description"]).to eq("Similar code found in 1 other location")
+        expect(json["description"]).to eq("Similar code found in 1 other location (mass = 18)")
         expect(json["categories"]).to eq(["Duplication"])
         expect(json["location"]).to eq({
           "path" => "foo.rb",

spec/cc/engine/analyzers/violations_spec.rb

@@ -35,7 +35,7 @@ module CC::Engine::Analyzers
 
         expect(first_formatted[:type]).to eq("issue")
         expect(first_formatted[:check_name]).to eq("Identical code")
-        expect(first_formatted[:description]).to eq("Identical code found in 2 other locations")
+        expect(first_formatted[:description]).to eq("Identical code found in 2 other locations (mass = 18)")
         expect(first_formatted[:categories]).to eq(["Duplication"])
         expect(first_formatted[:remediation_points]).to eq(30)
         expect(first_formatted[:location]).to eq({:path=>"file.rb", :lines=>{:begin=>1, :end=>5}})