Merge branch 'main' into v4.4.0

Author: jsjoeio

.node-version

@@ -1 +1 @@
-14
+16

docs/CONTRIBUTING.md

@@ -31,7 +31,7 @@ for [VS
 Code](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites).
 Here is what is needed:
 
-- `node` v14.x
+- `node` v16.x
 - `git` v2.x or greater
 - [`git-lfs`](https://git-lfs.github.com)
 - [`yarn`](https://classic.yarnpkg.com/en/)

test/unit/node/update.test.ts

@@ -131,7 +131,8 @@ describe("update", () => {
 
     await expect(settings().read()).resolves.toEqual({ update })
     expect(isNaN(update.checked)).toEqual(false)
-    expect(update.checked < Date.now() && update.checked >= now).toEqual(true)
+    expect(update.checked).toBeGreaterThanOrEqual(now)
+    expect(update.checked).toBeLessThanOrEqual(Date.now())
     expect(update.version).toStrictEqual("2.1.0")
     expect(spy).toEqual(["/latest"])
   })
@@ -145,7 +146,7 @@ describe("update", () => {
 
     await expect(settings().read()).resolves.toEqual({ update })
     expect(isNaN(update.checked)).toStrictEqual(false)
-    expect(update.checked).toBeLessThan(now)
+    expect(update.checked).toBeLessThanOrEqual(now)
     expect(update.version).toStrictEqual("2.1.0")
     expect(spy).toEqual([])
   })
@@ -160,7 +161,7 @@ describe("update", () => {
     await expect(settings().read()).resolves.toEqual({ update })
     expect(isNaN(update.checked)).toStrictEqual(false)
     expect(update.checked).toBeGreaterThanOrEqual(now)
-    expect(update.checked).toBeLessThan(Date.now())
+    expect(update.checked).toBeLessThanOrEqual(Date.now())
     expect(update.version).toStrictEqual("4.1.1")
     expect(spy).toStrictEqual(["/latest"])
   })
@@ -206,15 +207,15 @@ describe("update", () => {
     let update = await provider.getUpdate(true)
     expect(isNaN(update.checked)).toStrictEqual(false)
     expect(update.checked).toBeGreaterThanOrEqual(now)
-    expect(update.checked).toBeLessThan(Date.now())
+    expect(update.checked).toBeLessThanOrEqual(Date.now())
     expect(update.version).toStrictEqual("unknown")
 
     provider = new UpdateProvider("http://probably.invalid.dev.localhost/latest", settings())
     now = Date.now()
     update = await provider.getUpdate(true)
     expect(isNaN(update.checked)).toStrictEqual(false)
     expect(update.checked).toBeGreaterThanOrEqual(now)
-    expect(update.checked).toBeLessThan(Date.now())
+    expect(update.checked).toBeLessThanOrEqual(Date.now())
     expect(update.version).toStrictEqual("unknown")
   })