Help needed with "make all-tests"

[chschnell]

My eventual goal is to run make all-tests locally, but that currently fails early in make target eslint, then later also in devices-test and there are issues in tests.

I'm building V86 on a Debian 12 (64 Bit) host, and I'm using eslint v6.4.0 from Debian's standard APT package repository, as well as npm 9.2.0.

make eslint

If I run make eslint I get this error:

$ make eslint
eslint src tests gen lib examples tools

Oops! Something went wrong! :(

ESLint: 6.4.0.

ESLint couldn't find a configuration file. To set up a configuration file for this project, please run:

    eslint --init

ESLint looked for configuration files in /home/cs/v86-fix-cdrom-hda-boot/src and its ancestors. If it found none, it then looked in your home directory.

If you think you already have a configuration file or if you need more help, please stop by the ESLint chat room: https://gitter.im/eslint/eslint

make: *** [Makefile:373: eslint] Fehler 2

Running the suggested eslint --init I get:

$ eslint --init
Error: Cannot find module 'inquirer'
Require stack:
- /usr/share/nodejs/eslint/lib/init/config-initializer.js
- /usr/share/nodejs/eslint/bin/eslint.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1134:15)
    at Module._load (node:internal/modules/cjs/loader:975:27)
    at Module.require (node:internal/modules/cjs/loader:1225:19)
    at require (/usr/share/nodejs/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/usr/share/nodejs/eslint/lib/init/config-initializer.js:15:16)
    at Module._compile (/usr/share/nodejs/v8-compile-cache/v8-compile-cache.js:192:30)
    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
    at Module.load (node:internal/modules/cjs/loader:1197:32)
    at Module._load (node:internal/modules/cjs/loader:1013:12)
    at Module.require (node:internal/modules/cjs/loader:1225:19)

Further attempts to install inquirer using npm install inquirer (as suggested in the inquirer documentation) failed.

How am I supposed to install eslint?

make devices-test

There seem to be 15 make targets for testing, all PASS locally here except for eslint and devices-test, the latter finishes with:

Tests finished.
[-] Failed 5 out of 29 tests:
#14 Statfs (failure allowed)
#16 Xattrwalk and Listxattr (failure allowed)
#17 Xattrcreate (failure allowed)
#18 Report All Security Capabilities (failure allowed)
[-] #19 File Locks

Failed test #19 (File Locks) is not allowed to fail, and thus the make target fails.

make tests

When running make tests, all images pass except for:

• experimental/VirtualXP.iso
• experimental/copy_winxp_lite-from-pixelsuft.img
• windows2k.img
• winnt4_noacpi.img
• winnt31.img
• w95.img

They all timeout. I've removed these image files and the corresponding tests get skipped, but is this to be expected?

[SuperMaxusa]

I'm using eslint v6.4.0 from Debian's standard APT package repository

This is an outdated version, can you remove it, run npm i -g eslint and try again? I would also suggest to use a node/npm with nvm or volta, not Debian's system-wide.

When running make tests, all images pass except for:

Tests with these images are skipped if the required files are not found. What is your list of files in the images/ folder?

[chschnell]

I'm using eslint v6.4.0 from Debian's standard APT package repository

This is an outdated version, can you remove it, run npm i -g eslint and try again? I would also suggest to use a node/npm with nvm or volta, not Debian's system-wide.

I purged all Debian node, npm and eslint APT packages, then installed latest node, npm and eslint using:

$ sudo curl -fsSL https://deb.nodesource.com/setup_20.x | sudo -E bash - && sudo apt install nodejs -y
$ sudo npm i -g eslint

Which now gives:

$ node --version
v20.19.1
$ npm --version
11.3.0
$ eslint --version
v9.26.0

And now make eslint just works, thank you so much @SuperMaxusa! Also, make all-tests completed without errors now, great!

When running make tests, all images pass except for:

Tests with these images are skipped if the required files are not found. What is your list of files in the images/ folder?

$ ls images/
buildroot-bzimage68.bin  kolibri.img  linux4.iso  oberon.img          os8.img                    snowdrop.img
freedos722.img           linux3.iso   linux.iso   openbsd-floppy.img  qnx-demo-network-4.05.img  windows101.img

When I add Windows 95 images/w95.img and run make tests I get:

Test failed: Windows 95 (failure allowed)

Expected graphical mode after 120 seconds.
Expected mouse activation after 120 seconds.

Or when I add Windows 2000 images/windows2k.img:

+==================================== SCREEN ====================================+
|SeaBIOS (version rel-1.16.2-0-gea1b7a0)                                         |
|Booting from Hard Disk...                                                       |
|Boot failed: could not read the boot disk                                       |
|                                                                                |
|Booting from Floppy...                                                          |
|Boot failed: could not read the boot disk                                       |
|                                                                                |
|No bootable device.  Retrying in 60 seconds.                                    |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
|                                                                                |
+================================================================================+
Test failed: Windows 2000

Expected graphical mode after 300 seconds.
Expected mouse activation after 300 seconds.

So it fails to find its boot disk?

That's why I removed those 6 images from images/. Are these images supposed to PASS or FAIL?

[SuperMaxusa]

So it fails to find its boot disk?

If you left out placeholders for these images, the test script expects that file exists and can run the test.

v86/tests/full/run.js

Lines 118 to 121 in a3840e3

	{
	name: "Snowdrop",
	skip_if_disk_image_missing: true,
	fda: root_path + "/images/snowdrop.img",

v86/tests/full/run.js

Lines 1004 to 1014 in a3840e3

	const missing_images = images.filter(i => !fs.existsSync(i));
	if(missing_images.length)
	{
	if(test.skip_if_disk_image_missing)
	{
	console.warn("Missing disk image: " + missing_images.join(", ") + ", test skipped");
	console.warn();
	done();
	return;
	}

Are these images supposed to PASS or FAIL?

This shouldn't affect the overall test result, for example: https://github.com/copy/v86/actions/runs/14946336025/job/41990128459#step:23:2736

Here is a minimal set of OS images for testing (almost the same as used in CI):

v86/Readme.md

Line 151 in a3840e3

`wget -P images/ https://i.copy.sh/{linux3.iso,linux.iso,linux4.iso,buildroot-bzimage68.bin,openbsd-floppy.img,kolibri.img,windows101.img,os8.img,freedos722.img}`