Skip to content

Commit d9b31e0

Browse files
authored
chore!(backend-shared): make CUBEJS_TRANSPILATION_WORKER_THREADS=true by default (#10097)
* make CUBEJS_TRANSPILATION_WORKER_THREADS=true by default * cleanup push CI wf
1 parent 9e3a9fe commit d9b31e0

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

.github/workflows/push.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,8 @@ jobs:
8686
node-version: [22.x]
8787
# Don't forget to update build-native-release
8888
python-version: [3.11]
89-
transpile-worker-threads: [false, true]
9089
fail-fast: false
9190

92-
env:
93-
CUBEJS_TRANSPILATION_WORKER_THREADS: ${{ matrix.transpile-worker-threads }}
9491
steps:
9592
- id: get-tag-out
9693
run: echo "$OUT"
@@ -144,16 +141,16 @@ jobs:
144141
- name: Lerna test
145142
run: yarn lerna run --concurrency 1 --stream --no-prefix unit
146143
- name: Fix lcov paths
147-
if: (matrix.node-version == '22.x' && matrix.transpile-worker-threads == true)
144+
if: (matrix.node-version == '22.x')
148145
run: |
149146
./.github/actions/codecov-fix.sh
150147
- name: Combine all fixed LCOV files
151-
if: (matrix.node-version == '22.x' && matrix.transpile-worker-threads == true)
148+
if: (matrix.node-version == '22.x')
152149
run: |
153150
echo "" > ./combined-unit.lcov
154151
find ./packages -type f -name lcov.fixed.info -exec cat {} + >> ./combined-unit.lcov || true
155152
- name: Upload coverage artifact
156-
if: (matrix.node-version == '22.x' && matrix.transpile-worker-threads == true)
153+
if: (matrix.node-version == '22.x')
157154
uses: actions/upload-artifact@v4
158155
with:
159156
name: coverage-unit

docs/pages/product/configuration/reference/environment-variables.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1405,7 +1405,7 @@ code in worker threads.
14051405

14061406
| Possible Values | Default in Development | Default in Production |
14071407
| --------------- | ---------------------- | --------------------- |
1408-
| `true`, `false` | `false` | `false` |
1408+
| `true`, `false` | `true` | `true` |
14091409

14101410
<ReferenceBox>
14111411

packages/cubejs-backend-shared/src/env.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ const variables: Record<string, (...args: any) => any> = {
229229
.default('true')
230230
.asBoolStrict(),
231231
transpilationWorkerThreads: () => get('CUBEJS_TRANSPILATION_WORKER_THREADS')
232-
.default('false')
232+
.default('true')
233233
.asBoolStrict(),
234234
allowNonStrictDateRangeMatching: () => get('CUBEJS_PRE_AGGREGATIONS_ALLOW_NON_STRICT_DATE_RANGE_MATCH')
235235
.default('true')

0 commit comments

Comments
 (0)