Insufficient contrast on hover state for links in tables in dark mode

[jacobtylerwalls]

See at https://www.djangoproject.com/download/ the footnote links under "Future Roadmap":

Screenshots with hover state forced on "1":
Dark mode (1.15:1 contrast, this is pretty unreadable):

I'm most concerned with dark mode. Light mode is better (2.79:1 contrast):

---

#2233 adds more links in these tables e.g. ("6.0" links to a roadmap)

[calebjubal]

Is it okay if I go for white?

[calebjubal]

@jacobtylerwalls can I start working on this?

[SaptakS]

@jacobtylerwalls thanks for creating an issue regarding this. @calebjubal feel free to work on it. I would probably make the footnote link (and other links in those boxes) match the color of the rest of the text for now. With the underline, it should still be identifiable as a link even without the difference in color.

[calebjubal]

@SaptakS what should I do, should I change the background to some other color, because the hover color is forced in the dark mode only, and in the light mode (_style.scss : base scss) there is no relevance for hover color on the links?

[SaptakS]

@calebjubal in the dark mode, you can change the hover color to something like #09422C. In light mode, you can change the default color to maybe var(--table-color) to make it more contrasty.

[calebjubal]

I tried to change both the dark mode color (#09422C) change went well:

but the color impact is mild for the light mode var(--table-color):

[calebjubal]

And @SaptakS what are the PR guidelines because there is no Contributing.md file, should I create that as well?

[SaptakS]

The changes look fine to me for now, as it fixes the bug. You can go ahead and open a PR, explaining the work done to fix it and attaching the screenshots.

there is no Contributing.md file

We are working on adding one soon.

[calebjubal]

@SaptakS please check for PR #2249

[calebjubal]

Hey @jacobtylerwalls and @SaptakS, does the PR normally take so much time or did I make any mistake while creating PR.

[SaptakS]

Hello @calebjubal since everyone in the website WG works in a volunteer basis, sometimes PR reviews and merging can take a little bit of time. Thanks for submitting the PR! I will take a look by end of this week.

[calebjubal]

I understand now, sorry @SaptakS if I was being impolite because I thought my PR was incorrect, please do take your time!