Skip to content

React and React-Dom should be added to dev and peer dependencies #13

@hjrdave

Description

@hjrdave

I am using this library as a dependency for a private npm package I am developing. I noticed I was having an issue developing my package locally because a dependency kept installing React when I did an npm install. This caused conflicts between my developer environment and local package. A symlink is usually used for both local projects to prevent this conflict. Upon further research I discovered 'react-spinners-kit' has react and react-dom in the dependencies which is causing it to automatically install. I believe best practice is to have it in peer dependencies and not dependencies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions