Skip to content

fix(remote-config): js interop types #17806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+7 −26
Open

fix(remote-config): js interop types #17806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
589f144
fix(remote-config): js interop types
MichaelVerdon Oct 22, 2025
95f75ea
fix: more js interop types
MichaelVerdon Oct 27, 2025
e6c6cd2
fix: invalid interop type
MichaelVerdon Oct 27, 2025
8639e9b
fix: getValue to dart
MichaelVerdon Oct 27, 2025
b500a09
fix: lint
MichaelVerdon Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...base_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ class RemoteConfig
remote_config_interop.getValue(jsObject, key.toJS).asString().toDart,
),
getSource(
remote_config_interop.getValue(jsObject, key.toJS).getSource().toDart,
remote_config_interop.getValue(jsObject, key.toJS).asString().toDart,
),
);

Expand Down
31 changes: 6 additions & 25 deletions ...ote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ external JSPromise fetchConfig(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
external JSAny getAll(RemoteConfigJsImpl remoteConfig);
external JSObject getAll(RemoteConfigJsImpl remoteConfig);

@JS()
@staticInterop
Expand Down Expand Up @@ -66,11 +66,7 @@ external JSPromise setCustomSignals(
@staticInterop
external void setLogLevel(RemoteConfigJsImpl remoteConfig, JSString logLevel);

@JS('RemoteConfig')
@staticInterop
abstract class RemoteConfigJsImpl {}

extension RemoteConfigJsImplExtension on RemoteConfigJsImpl {
extension type RemoteConfigJsImpl._(JSObject _) implements JSObject {
external AppJsImpl get app;
external SettingsJsImpl get settings;
external set settings(SettingsJsImpl value);
Expand All @@ -80,24 +76,14 @@ extension RemoteConfigJsImplExtension on RemoteConfigJsImpl {
external JSString get lastFetchStatus;
}

@JS()
@staticInterop
@anonymous
abstract class ValueJsImpl {}

extension ValueJsImplExtension on ValueJsImpl {
extension type ValueJsImpl._(JSObject _) implements JSObject {
external JSBoolean asBoolean();
external JSNumber asNumber();
external JSString asString();
external JSString getSource();
}

@JS()
@staticInterop
@anonymous
abstract class SettingsJsImpl {}

extension SettingsJsImplExtension on SettingsJsImpl {
extension type SettingsJsImpl._(JSObject _) implements JSObject {
external JSNumber get minimumFetchIntervalMillis;
external set minimumFetchIntervalMillis(JSNumber value);
external JSNumber get fetchTimeoutMillis;
Expand All @@ -115,18 +101,13 @@ abstract class ConfigUpdateObserver {
});
}

extension ConfigUpdateObserverJsImpl on ConfigUpdateObserver {
extension type ConfigUpdateObserverJsImpl._(JSObject _) implements JSObject {
external JSAny get next;
external JSAny get error;
external JSAny get complete;
}

@JS()
@staticInterop
@anonymous
abstract class ConfigUpdateJsImpl {}

extension ConfigUpdateJsImplExtension on ConfigUpdateJsImpl {
extension type ConfigUpdateJsImpl._(JSObject _) implements JSObject {
external JSSet getUpdatedKeys();
}

Expand Down
Loading