-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(cheats): get profile artifacts metadata #12150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xrusowsky
wants to merge
12
commits into
master
Choose a base branch
from
rusowsky/cheats-profile-metadata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
|
Ran into a test failure, maybe a regression? Ref: https://github.com/foundry-rs/foundry/actions/runs/18844750249/job/53782078338 |
|
Overall looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
towards #9840 (comment)
foundry is unable to fully support multichain deployments within a single script/run if the target chain have different EVM versions.
this is a summary of the issues/challenges that we face:
solc&evm_versionconfiguration. feat(cheatcodes): add setEvmVersion / getEvmVersion #12014 introduced the ability to select the evm version at runtime withsetEvmVersion()Solution
this PR introduces
getProfile()cheatcodes that forwards profile metadata (artifacts path and EVM version) to the script runner, which is the last missing piece.combined with
setEvmVersion(), anddeployCode()cheatcode, this enables:getProfile(): get the evm version and locate the correct artifacts directory for each chain.setEvmVersion(): switch to the required runtime environmentdeployCode(): deploy the bytecode of the corresponding artifactsImplementation Details
PR Checklist
Next Steps
leverage the new cheatcodes in forge-std so that users can have a smooth and safe multi-chain experience (simply by inheriting the
Configabstract).