fix versioning logic

Author: baronfel

fcs/Directory.Build.props

@@ -24,7 +24,7 @@
   <!-- SDK targets override -->
   <PropertyGroup>
     <FSharpSourcesRoot>$(MSBuildThisFileDirectory)..\src</FSharpSourcesRoot>
-    <VersionPrefix>22.0.3</VersionPrefix>
+    <VersionPrefix Condition="'$(VersionPrefix)' == ''">22.0.3</VersionPrefix>
     <OtherFlags>--version:$(VersionPrefix)</OtherFlags>
     <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>    
     <!-- FSharp.Compiler.Tools is currently only used to get a working FSI.EXE to execute some scripts during the build -->

fcs/RELEASE_NOTES.md

@@ -1,3 +1,6 @@
+#### 29.0.1
+  * Fix versioning of the assembly
+
 #### 29.0.0
   * Integrate visualfsharp master from 165b736b9 (2019-03-29) to 25560f477 (2019-05-24)
   * Notable improvements include:

fcs/build.fsx

@@ -91,7 +91,7 @@ Target "Build" (fun _ ->
     runDotnet __SOURCE_DIRECTORY__ "build ../src/buildtools/buildtools.proj -v n -c Proto"
     let fslexPath = __SOURCE_DIRECTORY__ + "/../artifacts/bin/fslex/Proto/netcoreapp2.1/fslex.dll"
     let fsyaccPath = __SOURCE_DIRECTORY__ + "/../artifacts/bin/fsyacc/Proto/netcoreapp2.1/fsyacc.dll"
-    runDotnet __SOURCE_DIRECTORY__ (sprintf "build FSharp.Compiler.Service.sln -v n -c Release /p:FsLexPath=%s /p:FsYaccPath=%s" fslexPath fsyaccPath)
+    runDotnet __SOURCE_DIRECTORY__ (sprintf "build FSharp.Compiler.Service.sln -v n -c Release /p:FsLexPath=%s /p:FsYaccPath=%s /p:VersionPrefix=%s" fslexPath fsyaccPath assemblyVersion)
 )
 
 Target "Test" (fun _ ->
@@ -110,12 +110,12 @@ let escapeString (s: string) =
 
 Target "NuGet" (fun _ ->
     let props =
-      [ "PackageVersion", (string release.NugetVersion)
+      [ "VersionPrefix", release.NugetVersion
         "PackageReleaseNotes", release.Notes |> String.concat "\n"]
       |> Seq.map (fun (prop, value) -> sprintf "-p:%s=%s" prop (escapeString value))
       |> String.concat " "
 
-    runDotnet __SOURCE_DIRECTORY__ (sprintf "pack FSharp.Compiler.Service.sln -v n -c Release %s" props)
+    runDotnet __SOURCE_DIRECTORY__ (sprintf "pack FSharp.Compiler.Service.sln --no-build -v n -c Release %s" props)
 )
 
 Target "GenerateDocsEn" (fun _ ->