Skip to content

Commit d11b056

Browse files
wallymathieuwallymathieu
committed
Merge remote-tracking branch 'origin/master' into gus/structured-format-display-for-collections
2 parents cef7c86 + 68b0dc1 commit d11b056

File tree

217 files changed

+10051
-2082
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

217 files changed

+10051
-2082
lines changed

‎.config/dotnet-tools.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
"isRoot": true,
44
"tools": {
55
"fable": {
6-
"version": "4.1.4",
6+
"version": "4.23.0",
77
"commands": [
88
"fable"
99
]
1010
},
1111
"fsdocs-tool": {
12-
"version": "17.2.3",
12+
"version": "19.1.1",
1313
"commands": [
1414
"fsdocs"
1515
]

‎.github/CODEOWNERS‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
@gusty
2+
@wallymathieu
3+
@fcallejon
4+
@cannorin
5+
@pnobre
6+

‎.github/ISSUE_TEMPLATE.md‎

Lines changed: 0 additions & 32 deletions
This file was deleted.

‎.github/ISSUE_TEMPLATE/01_bug_report.yml‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
name: 🐞 Bug Report
2+
description: Create a report to help us improve
3+
labels: ["bug", "triage"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
Note: the following is not mandatory, just a guideline. Feel free to describe your bug report or suggestion in another way.
9+
- type: textarea
10+
id: background
11+
attributes:
12+
label: Description
13+
description: Please provide a succinct description of your issue.
14+
placeholder: Description
15+
validations:
16+
required: true
17+
- type: textarea
18+
id: known-workarounds
19+
attributes:
20+
label: Known Workarounds
21+
description: Please provide a description of any known workarounds.
22+
placeholder: Known Workarounds
23+
validations:
24+
required: false
25+
- type: textarea
26+
id: expected-behavior
27+
attributes:
28+
label: Expected behavior
29+
description: Provide a description of the expected behavior.
30+
placeholder: Expected behavior
31+
validations:
32+
required: false
33+
- type: textarea
34+
id: actual-behavior
35+
attributes:
36+
label: Actual behavior
37+
description: |
38+
Provide a description of the actual behavior observed. If applicable please include any error messages or exception stack-traces.
39+
placeholder: Actual behavior
40+
validations:
41+
required: false
42+
- type: textarea
43+
id: configuration
44+
attributes:
45+
label: Configuration
46+
description: |
47+
Please provide more information on your .NET configuration:
48+
* Operating system
49+
* Branch/Version
50+
* .NET Runtime, CoreCLR or Mono Version
51+
* Performance information, links to performance testing scripts
52+
placeholder: Configuration
53+
validations:
54+
required: false
55+
- type: textarea
56+
id: repro-steps
57+
attributes:
58+
label: Reproduction Steps
59+
description: |
60+
Please include minimal steps to reproduce the problem if possible. E.g.: the smallest possible code snippet; or a small project, with steps to run it.
61+
Always include text as text rather than screenshots so code can easily be copied and will show up in searches.
62+
Stack Overflow has a great article about [how to create a minimal, reproducible example](https://stackoverflow.com/help/minimal-reproducible-example).
63+
placeholder: Minimal Reproduction
64+
validations:
65+
required: false
66+
- type: dropdown
67+
id: pull-request
68+
attributes:
69+
label: Are you willing to help with a pull-request?
70+
description: |
71+
Make sure you have read the sections about [contributing changes](https://github.com/fsprojects/FSharpPlus/blob/master/DEVELOPER_GUIDE.md) and [design guidelines](https://github.com/fsprojects/FSharpPlus/blob/master/DESIGN_GUIDELINES.md).
72+
options:
73+
- "No"
74+
- "Yes, please assign this issue to me."
75+
validations:
76+
required: true

‎.github/ISSUE_TEMPLATE/02_api_proposal.yml‎

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
name: 💡 API Suggestion
2+
description: Propose a change to the public API surface
3+
title: "[API Proposal]: "
4+
labels: [api-suggestion]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
We welcome API proposals! We have a process to evaluate the value and shape of new API. This template will help us gather the information we need to start the review process.
10+
- type: textarea
11+
id: background
12+
attributes:
13+
label: Background and motivation
14+
description: Please describe the purpose and value of the new API here.
15+
placeholder: Purpose
16+
validations:
17+
required: true
18+
- type: textarea
19+
id: api-proposal
20+
attributes:
21+
label: API Proposal
22+
description: |
23+
Please provide the specific public API signature diff that you are proposing.
24+
placeholder: API declaration (no function bodies)
25+
validations:
26+
required: true
27+
- type: textarea
28+
id: api-usage
29+
attributes:
30+
label: API Usage
31+
description: |
32+
Please provide code examples that highlight how the proposed API additions are meant to be consumed. This will help suggest whether the API has the right shape to be functional, performant and usable.
33+
placeholder: API usage
34+
validations:
35+
required: true
36+
- type: textarea
37+
id: alternative-designs
38+
attributes:
39+
label: Alternative Designs
40+
description: |
41+
Please provide alternative designs. This might not be APIs; for example instead of providing new APIs an option might be to change the behavior of an existing API.
42+
placeholder: Alternative designs
43+
validations:
44+
required: false
45+
- type: textarea
46+
id: risks
47+
attributes:
48+
label: Risks
49+
description: |
50+
Please mention any risks that to your knowledge the API proposal might entail, such as breaking changes, performance regressions, etc.
51+
placeholder: Risks
52+
validations:
53+
required: false
54+
- type: dropdown
55+
id: pull-request
56+
attributes:
57+
label: Are you willing to help with a proof-of-concept (as PR in that or a separate repo) first and as pull-request later on?
58+
description: |
59+
This is mainly to help demonstrate your suggestion.
60+
Make sure you have read the sections about [contributing changes](https://github.com/fsprojects/FSharpPlus/blob/master/DEVELOPER_GUIDE.md) and [design guidelines](https://github.com/fsprojects/FSharpPlus/blob/master/DESIGN_GUIDELINES.md).
61+
Beware we might not accept the PR as is, but it will help us understand your suggestion better.
62+
options:
63+
- "No"
64+
- "Yes, please assign this issue to me."
65+
validations:
66+
required: true

‎.github/ISSUE_TEMPLATE/03_general_feature.yml‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
name: 💡 General feature (not including API proposals)
2+
description: Discuss a new feature that does not change the public API surface
3+
title: "[Feature]: "
4+
labels: [feature, triage]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
You have an idea for a new feature? Cool, let's discuss it.
10+
- type: textarea
11+
id: background
12+
attributes:
13+
label: Background and motivation
14+
description: Please describe the purpose of the new feature.
15+
placeholder: Purpose
16+
validations:
17+
required: true
18+
- type: textarea
19+
id: alternative-concerns
20+
attributes:
21+
label: Alternative Concerns
22+
description: |
23+
Please provide alternatives you have thought about.
24+
placeholder: Alternative designs
25+
validations:
26+
required: false
27+
- type: dropdown
28+
id: pull-request
29+
attributes:
30+
label: Are you willing help with a pull-request?
31+
description: |
32+
Make sure you have read the sections about [contributing changes](https://github.com/fsprojects/FSharpPlus/blob/master/DEVELOPER_GUIDE.md) and [design guidelines](https://github.com/fsprojects/FSharpPlus/blob/master/DESIGN_GUIDELINES.md).
33+
Beware we might not accept the PR as is, but it will help us understand your suggestion better.
34+
options:
35+
- "No"
36+
- "Yes, please assign this issue to me."
37+
validations:
38+
required: true

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
blank_issues_enabled: true
2+
contact_links:
3+
- name: 📚 Documentation
4+
url: https://fsprojects.github.io/FSharpPlus/
5+
about: Read our documentation.
6+
- name: 💬 Ask on Stack Overflow
7+
url: https://stackoverflow.com/questions/tagged/f%23%2b
8+
about: The best place for asking general purpose questions.

‎.github/release.yml‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
changelog:
2+
exclude:
3+
labels:
4+
- changelog-ignore
5+
authors: [ ]
6+
categories:
7+
- title: Breaking Changes
8+
labels:
9+
- "breaking change"
10+
- title: New features
11+
labels:
12+
- "feature"
13+
- "add"
14+
- title: Improvements
15+
labels:
16+
- "enhancement"
17+
- "performance"
18+
- title: Fixes
19+
labels:
20+
- "bug"
21+
- "regression"
22+
- "fix"
23+
- title: Documentation
24+
labels:
25+
- "documentation"
26+
- title: Others
27+
labels:
28+
- "*"

‎.github/workflows/dotnetcore.yml‎

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ env:
55
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
66
# Disable sending usage data to Microsoft
77
DOTNET_CLI_TELEMETRY_OPTOUT: true
8-
# GitHub Packages Feed settings
9-
GITHUB_FEED: https://nuget.pkg.github.com/fsprojects
10-
GITHUB_USER: fsprojects
11-
#GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
128

139
on:
1410
push:
@@ -23,32 +19,38 @@ jobs:
2319
steps:
2420
- uses: actions/checkout@v2
2521
- name: Setup .NET Core
26-
uses: actions/setup-dotnet@v1
22+
uses: actions/setup-dotnet@v3
2723
with:
28-
dotnet-version: 7.0.100
24+
dotnet-version: |
25+
8.0.x
26+
7.0.x
2927
- name: Restore
3028
run: git submodule update --init --recursive
3129
- name: Build with dotnet
3230
run: dotnet build build.proj --configuration Release
31+
- name: Set Timezone
32+
uses: szenius/set-timezone@v1.2
33+
with:
34+
timezoneWindows: "Nepal Standard Time"
3335
- name: Test with dotnet
3436
run: dotnet test build.proj -v n
3537

3638
package:
3739
runs-on: windows-latest
38-
40+
permissions:
41+
packages: write
42+
contents: read
3943
steps:
4044
- uses: actions/checkout@v2
41-
- name: Setup .NET Core 7
42-
uses: actions/setup-dotnet@v1
43-
with:
44-
dotnet-version: 7.0.100
45-
- name: Setup .NET Core 6
46-
uses: actions/setup-dotnet@v1
45+
- name: Setup .NET Core
46+
uses: actions/setup-dotnet@v3
4747
with:
48-
dotnet-version: 6.0.201
48+
dotnet-version: |
49+
8.0.x
50+
7.0.x
51+
6.0.x
4952
- name: Restore
5053
run: git submodule update --init --recursive
51-
5254
- name: Extract branch name
5355
shell: bash
5456
run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})"
@@ -66,34 +68,32 @@ jobs:
6668
- name: Package
6769
run: dotnet pack build.proj --version-suffix ${{ steps.version_suffix.outputs.version_suffix }}
6870
- name: Upload Artifacts
69-
uses: actions/upload-artifact@v2
71+
uses: actions/upload-artifact@v4
7072
with:
71-
name: nupkg
73+
name: nupkg-${{ matrix.runs-on }}
7274
path: ./bin/nupkg/*.nupkg
73-
#- name: Push to GitHub Feed
74-
# shell: bash
75-
# run: |
76-
# for f in ./bin/nupkg/*.nupkg
77-
# do
78-
# curl -vX PUT -u "$GITHUB_USER:$GITHUB_TOKEN" -F package=@$f $GITHUB_FEED
79-
# done
75+
- name: Push to GitHub Feed
76+
continue-on-error: true
77+
shell: bash
78+
run: |
79+
for f in ./bin/nupkg/*.nupkg
80+
do
81+
echo $f
82+
dotnet nuget push $f -k ${{ secrets.GITHUB_TOKEN }} -s https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json
83+
done
8084
8185
docs:
8286
runs-on: windows-latest
8387
steps:
8488
- uses: actions/checkout@v2
85-
- name: Setup .NET Core 7
86-
uses: actions/setup-dotnet@v1
87-
with:
88-
dotnet-version: 7.0.100
89-
- name: Setup .NET Core 6
90-
uses: actions/setup-dotnet@v1
91-
with:
92-
dotnet-version: 6.0.201
93-
- name: Setup .NET Core 5
94-
uses: actions/setup-dotnet@v1
89+
- name: Setup .NET Core
90+
uses: actions/setup-dotnet@v3
9591
with:
96-
dotnet-version: 5.0.405
92+
dotnet-version: |
93+
8.0.x
94+
7.0.x
95+
6.0.x
96+
5.0.x
9797
- name: Restore
9898
run: git submodule update --init --recursive
9999
- name: Build All Docs

0 commit comments

Comments
 (0)