How to lint for testing folders without a main.go in Azure DevOps?

[tuxerrante]

Hi,
I need to scan a testing folder with a structure like

go.mod
go.sum
test/
 - a_test.go
 - b_test.go
 - ...

I've tried many combinations of the args to mount the current dir as a volume, the test folder, copying go.mod and go.sum in test folder before mounting it and so on.

> cp go.mod go.sum test/
> docker run --rm -v $(pwd)/test:/app -w /app  golangci/golangci-lint:v1.59.1 golangci-lint run -v --fast --no-config --exclude-dirs "ci"

level=info msg="golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z"
level=info msg="[lintersdb] Active 1 linters: [ineffassign]"
level=info msg="[loader] Go packages loading at mode 7 (compiled_files|files|name) took 39.280846ms"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 1.31897ms"
level=**error** msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"
level=info msg="[linters_context/goanalysis] analyzers took 162.358µs with top 10 stages: typecheck: 97.406µs, ineffassign: 64.952µs"
level=info msg="[runner] processing took 3.893µs with stages: max_same_issues: 667ns, skip_dirs: 568ns, max_from_linter: 476ns, nolint: 219ns, cgo: 176ns, fixer: 150ns, path_prefixer: 148ns, invalid_issue: 147ns, exclude: 139ns, filename_unadjuster: 137ns, path_prettifier: 137ns, skip_files: 136ns, max_per_file_from_linter: 135ns, identifier_marker: 134ns, source_code: 126ns, path_shortener: 62ns, uniq_by_line: 60ns, diff: 57ns, sort_results: 57ns, severity-rules: 56ns, autogenerated_exclude: 55ns, exclude-rules: 51ns"
level=info msg="[runner] linters took 137.527811ms with stages: goanalysis_metalinter: 137.445973ms"
level=info msg="File cache stats: 0 entries of total size 0B"
level=info msg="Memory: 3 samples, avg is 21.6MB, max is 21.6MB"
level=info msg="Execution took 185.406873ms"

Or:

cp go.mod go.sum test/
+ ls -l test/
-rw-r--r-- 1 root root    737 Jul  1 11:36 ai_test.go
-rw-r--r-- 1 root root   7476 Jul  1 20:56 go.mod
-rw-r--r-- 1 root root 127156 Jul  1 20:56 go.sum
...
> docker run --rm \
    -v "${GOPATH}"/pkg/mod:/go/pkg/mod \
    -v "$(pwd)/test":/app \
    -w /app \
    golangci/golangci-lint:v1.59.1 \
    golangci-lint run -v --fast \
    --no-config \
    --exclude-dirs "ci" \
    --modules-download-mode=readonly \
    --sort-results app/

level=info msg="golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z"
level=info msg="[lintersdb] Active 1 linters: [ineffassign]"
level=info msg="[loader] Go packages loading at mode 7 (compiled_files|files|name) took 12.024713ms"
level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: go.mod file not found in current directory or any parent directory; see 'go help modules'\n"
level=info msg="Memory: 2 samples, avg is 21.8MB, max is 21.8MB"
level=info msg="Execution took 17.697816ms"

[ldez]

Hello,

I think it's because your go.mod if not up-to-date, you should run a go mod tidy.

Demo

.
├── foo
│   └── foo_test.go
└── go.mod

go.mod:

module github.com/example/example

go 1.21

foo/foo_test.go:

package foo

import (
	"fmt"
	"testing"
)

func TestName(t *testing.T) {
	foo("r")
}

func foo(a string) error {
	if a == "a" {
		return nil
	}

	return fmt.Errorf("foo")
}

$ golangci-lint run
foo/foo_test.go:9:5: Error return value is not checked (errcheck)
        foo("r")
           ^
$ 

[tuxerrante]

Thanks for the support,
unluckily this doesn't seem the case since locally from WSL2 + Docker it works fine, while running on Azure DevOps Server in an Azure Pipeline bash task, it fails.

Local run:

➜ go mod tidy &&\
  cp go.mod go.sum test/ &&\
  docker run --rm \
    -v "$(pwd)/test":/app \
    -w /app \
    golangci/golangci-lint:v1.59.1 \
    golangci-lint run -v --fast \
    --no-config \
    --exclude-dirs "ci" \
    --modules-download-mode=readonly 

level=info msg="golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z"
level=info msg="[lintersdb] Active 1 linters: [ineffassign]"
level=info msg="[loader] Go packages loading at mode 7 (name|files|compiled_files) took 1.35680959s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 25.450485ms"
level=info msg="[linters_context/goanalysis] analyzers took 2.213805ms with top 10 stages: ineffassign: 2.160148ms, typecheck: 53.657µs"
level=info msg="[runner] processing took 3.689µs with stages: skip_dirs: 1.084µs, nolint: 625ns, max_same_issues: 359ns, skip_files: 282ns, max_from_linter: 193ns, cgo: 161ns, filename_unadjuster: 140ns, invalid_issue: 125ns, identifier_marker: 120ns, path_prefixer: 75ns, uniq_by_line: 72ns, path_shortener: 61ns, diff: 51ns, source_code: 46ns, sort_results: 44ns, autogenerated_exclude: 43ns, exclude: 41ns, fixer: 36ns, path_prettifier: 34ns, exclude-rules: 33ns, max_per_file_from_linter: 32ns, severity-rules: 32ns"
level=info msg="[runner] linters took 57.089709ms with stages: goanalysis_metalinter: 56.947038ms"
level=info msg="File cache stats: 0 entries of total size 0B"
level=info msg="Memory: 16 samples, avg is 26.4MB, max is 30.3MB"
level=info msg="Execution took 1.447973245s"

go.mod

module ados.COMPANY/XX/YY/_git/XYZ-project.git

go 1.22.0

toolchain go1.22.4

require (
	github.com/Azure/azure-sdk-for-go v68.0.0+incompatible
	...
)

require (
	cloud.google.com/go v0.110.0 // indirect
	cloud.google.com/go/compute/metadata v0.3.0 // indirect
	...
)

From the Azure agent:
Without the target folder: pattern ./...: directory prefix . does not contain main module or its selected dependencies

docker run --rm -v /azp/agent/_work/2/s/test:/app -w /app golangci/golangci-lint:v1.59.1 golangci-lint run -v --fast --no-config --exclude-dirs ci --modules-download-mode=readonly --sort-results

Unable to find image 'golangci/golangci-lint:v1.59.1' locally
v1.59.1: Pulling from golangci/golangci-lint
...
Digest: sha256:b5f8712114561f1e2fbe74d04ed07ddfd992768705033a6251f3c7b848eac38e
Status: Downloaded newer image for golangci/golangci-lint:v1.59.1
level=info msg="golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z"
level=info msg="[lintersdb] Active 1 linters: [ineffassign]"
level=info msg="[loader] Go packages loading at mode 7 (files|name|compiled_files) took 41.837441ms"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 28.99µs"
level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"
level=info msg="[linters_context/goanalysis] analyzers took 138.54µs with top 10 stages: ineffassign: 96.307µs, typecheck: 42.233µs"
level=info msg="[runner] processing took 4.461µs with stages: max_same_issues: 955ns, skip_dirs: 357ns, exclude: 273ns, cgo: 257ns, max_from_linter: 247ns, filename_unadjuster: 168ns, skip_files: 167ns, invalid_issue: 165ns, sort_results: 163ns, identifier_marker: 163ns, path_prettifier: 159ns, nolint: 159ns, max_per_file_from_linter: 155ns, diff: 155ns, path_prefixer: 152ns, source_code: 151ns, autogenerated_exclude: 144ns, fixer: 143ns, path_shortener: 105ns, uniq_by_line: 80ns, exclude-rules: 74ns, severity-rules: 69ns"
level=info msg="[runner] linters took 16.139495ms with stages: goanalysis_metalinter: 16.017345ms"
level=info msg="File cache stats: 0 entries of total size 0B"
level=info msg="Memory: 2 samples, avg is 22.1MB, max is 22.1MB"
level=info msg="Execution took 67.170658ms"

Adding the target folder /app at the end of the command changes the error message "go.mod file not found"

> Currrent folder: /azp/agent/_work/13/s
total 464
drwxr-xr-x 5 root root   4096 Jul  2 07:42 ci
-rw-r--r-- 1 root root   6596 Jul  2 08:13 go.mod
-rw-r--r-- 1 root root 116257 Jul  2 08:13 go.sum
drwxr-xr-x 3 root root   4096 Jul  2 08:13 test
...

cp go.mod go.sum test/

+ docker run --rm -v /azp/agent/_work/13/s/test:/app -w /app golangci/golangci-lint:v1.59.1 golangci-lint run -v --fast --no-config --exclude-dirs ci /app

level=info msg="golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z"
level=info msg="[lintersdb] Active 1 linters: [ineffassign]"
level=info msg="[loader] Go packages loading at mode 7 (files|name|compiled_files) took 12.696137ms"
level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: err: exit status 1: stderr: go: go.mod file not found in current directory or any parent directory; see 'go help modules'\n"
level=info msg="Memory: 2 samples, avg is 26.1MB, max is 26.1MB"
level=info msg="Execution took 19.428673ms"

Launching directly the binary work fine also from inside the test folder