chore: remove state provider height

Author: prestwich

crates/block-processor/src/alias.rs

@@ -55,22 +55,22 @@ pub trait AliasOracleFactory: Send + Sync + 'static {
     type Oracle: AliasOracle;
 
     /// Create a new [`AliasOracle`].
-    fn create(&self, block_height: u64) -> eyre::Result<Self::Oracle>;
+    fn create(&self) -> eyre::Result<Self::Oracle>;
 }
 
 impl AliasOracleFactory for Box<dyn StateProviderFactory> {
     type Oracle = Box<dyn StateProvider>;
 
-    fn create(&self, block_height: u64) -> eyre::Result<Self::Oracle> {
-        self.state_by_block_number_or_tag(block_height.into()).map_err(Into::into)
+    fn create(&self) -> eyre::Result<Self::Oracle> {
+        self.state_by_block_number_or_tag(alloy::eips::BlockNumberOrTag::Latest).map_err(Into::into)
     }
 }
 
 /// This implementation is primarily for testing purposes.
 impl AliasOracleFactory for HashSet<Address> {
     type Oracle = HashSet<Address>;
 
-    fn create(&self, _block_height: u64) -> eyre::Result<Self::Oracle> {
+    fn create(&self) -> eyre::Result<Self::Oracle> {
         Ok(self.clone())
     }
 }
@@ -81,10 +81,10 @@ where
 {
     type Oracle = T::Oracle;
 
-    fn create(&self, block_height: u64) -> eyre::Result<Self::Oracle> {
+    fn create(&self) -> eyre::Result<Self::Oracle> {
         let guard =
             self.lock().map_err(|_| eyre::eyre!("failed to lock AliasOracleFactory mutex"))?;
-        guard.create(block_height)
+        guard.create()
     }
 }
 
@@ -94,7 +94,7 @@ where
 {
     type Oracle = T::Oracle;
 
-    fn create(&self, block_height: u64) -> eyre::Result<Self::Oracle> {
-        self.as_ref().create(block_height)
+    fn create(&self) -> eyre::Result<Self::Oracle> {
+        self.as_ref().create()
     }
 }

crates/block-processor/src/v1/processor.rs

@@ -112,8 +112,8 @@ where
     }
 
     /// Check if the given address should be aliased.
-    fn should_alias(&self, address: Address, host_height: u64) -> eyre::Result<bool> {
-        self.alias_oracle.create(host_height)?.should_alias(address)
+    fn should_alias(&self, address: Address) -> eyre::Result<bool> {
+        self.alias_oracle.create()?.should_alias(address)
     }
 
     /// Called when the host chain has committed a block or set of blocks.
@@ -267,7 +267,7 @@ where
         let mut to_alias: HashSet<Address> = Default::default();
         for transact in block_extracts.transacts() {
             let addr = transact.host_sender();
-            if !to_alias.contains(&addr) && self.should_alias(addr, host_height)? {
+            if !to_alias.contains(&addr) && self.should_alias(addr)? {
                 to_alias.insert(addr);
             }
         }