Skip to content

Conversation

@soundproofboot
Copy link
Contributor

@soundproofboot soundproofboot commented Jun 17, 2025

resolves #2082

Changes:

  • Update code blocks and text for the Angular Photo App tutorial to show additional context for each step with comments to indicate new lines.

Preview

@soundproofboot soundproofboot requested a review from a team as a code owner June 17, 2025 18:22
@soundproofboot soundproofboot requested a review from gnbm June 17, 2025 18:22
@vercel
Copy link

vercel bot commented Jun 17, 2025

@soundproofboot is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-docs Ready Ready Preview Comment Oct 31, 2025 0:38am

@brandyscarney brandyscarney changed the title docs(angular): "Your First App" tutorial should show complete code context(#2082) docs(angular): show complete code context in the "Your First App" tutorial Jun 23, 2025
@brandyscarney brandyscarney requested review from thetaPC and removed request for gnbm June 23, 2025 15:28
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update Page 7 Live reload to include more complete code.

soundproofboot and others added 15 commits June 26, 2025 09:19
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Fixed typo in the congratulations message regarding user devices.
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thetaPC I left some comments with requested changes. In many of these cases the code appears in more than the one place I commented. Additionally, we should probably make the same changes across all 3 PRs (React & Vue).

The only major change I would request is to convert this to follow a Standalone app.

Note: I did not do a thorough code review due to the possibility of converting this to Standalone. I will do that after all requested changes are made.


<ion-grid>
<ion-row>
<ion-col size="6" *ngFor="let photo of photoService.photos; index as position">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be using ngFor, the new way is to use @for: https://angular.dev/api/core/@for

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thetaPC You can ignore this feedback too - let's just do it on the standalone conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Your First App" tutorial should show complete code context - Angular

3 participants