Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Commit 571f1ca

Browse files
committed
remove prelights due to issues
1 parent 6e8007a commit 571f1ca

File tree

3 files changed

+3
-19
lines changed

3 files changed

+3
-19
lines changed

common/base.cc

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +0,0 @@
1-
#include "base.h"
2-
3-
void BaseProvider::handlePrelight(
4-
const HttpRequestPtr &req,
5-
std::function<void(const HttpResponsePtr &)> &&callback) {
6-
auto resp = drogon::HttpResponse::newHttpResponse();
7-
resp->setStatusCode(drogon::HttpStatusCode::k200OK);
8-
resp->addHeader("Access-Control-Allow-Origin", "*");
9-
resp->addHeader("Access-Control-Allow-Methods", "POST, OPTIONS");
10-
resp->addHeader("Access-Control-Allow-Headers", "*");
11-
callback(resp);
12-
}

common/base.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ class BaseProvider {
2727
virtual void
2828
modelStatus(const HttpRequestPtr &req,
2929
std::function<void(const HttpResponsePtr &)> &&callback) = 0;
30-
31-
// Additional methods
32-
void handlePrelight(const HttpRequestPtr &req,
33-
std::function<void(const HttpResponsePtr &)> &&callback);
3430
};
3531

3632
class ChatProvider : public BaseProvider {

controllers/llamaCPP.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2511,7 +2511,7 @@ append_to_generated_text_from_generated_token_probs(llama_server_context &llama,
25112511
using namespace drogon;
25122512

25132513
namespace inferences {
2514-
class llamaCPP : public ChatProvider, public drogon::HttpController<llamaCPP> {
2514+
class llamaCPP : public drogon::HttpController<llamaCPP>, public ChatProvider {
25152515
public:
25162516
llamaCPP();
25172517
~llamaCPP();
@@ -2525,10 +2525,10 @@ class llamaCPP : public ChatProvider, public drogon::HttpController<llamaCPP> {
25252525

25262526
// Openai compatible path
25272527
ADD_METHOD_TO(llamaCPP::inference, "/v1/chat/completions", Post);
2528-
ADD_METHOD_TO(llamaCPP::handlePrelight, "/v1/chat/completions", Options);
2528+
// ADD_METHOD_TO(llamaCPP::handlePrelight, "/v1/chat/completions", Options); NOTE: prelight will be added back when browser support is properly planned
25292529

25302530
ADD_METHOD_TO(llamaCPP::embedding, "/v1/embeddings", Post);
2531-
ADD_METHOD_TO(llamaCPP::handlePrelight, "/v1/embeddings", Options);
2531+
//ADD_METHOD_TO(llamaCPP::handlePrelight, "/v1/embeddings", Options);
25322532

25332533
// PATH_ADD("/llama/chat_completion", Post);
25342534
METHOD_LIST_END

0 commit comments

Comments
 (0)