From 2eafa7d7a8f6c03ffa844aafc6207f051f158ee4 Mon Sep 17 00:00:00 2001 From: Javier Tinoco <213990346+javiert-okta@users.noreply.github.com> Date: Wed, 8 Oct 2025 17:00:24 -0500 Subject: [PATCH 1/7] delete unecessary test --- e2e/decoder.spec.ts | 34 ---------------------------------- 1 file changed, 34 deletions(-) diff --git a/e2e/decoder.spec.ts b/e2e/decoder.spec.ts index dc6e7231..623a7130 100644 --- a/e2e/decoder.spec.ts +++ b/e2e/decoder.spec.ts @@ -105,32 +105,6 @@ test.describe("Can generate JWT examples", () => { await page.goto(E2E_BASE_URL); }); - test("Can open and close JWT Decoder example widget", async ({ page }) => { - const lang = await getLang(page); - expectToBeNonNull(lang); - - const pickersUiDictionary = getPickersUiDictionary(lang); - - const decoderWidget = page.getByTestId(dataTestidDictionary.decoder.id); - - const exampleButton = decoderWidget.getByRole("button", { - name: pickersUiDictionary.exampleAlgPicker.label, - }); - - await exampleButton.click(); - - await expect(exampleButton).not.toBeVisible(); - - const closeButton = page.getByRole("button", { - name: pickersUiDictionary.exampleAlgPicker.closeButton.label, - }); - - await closeButton.click(); - - await expect(exampleButton).toBeVisible(); - await expect(closeButton).not.toBeVisible(); - }); - test.describe("Can generate a JWT decoder example", () => { test.beforeEach(async ({ page }) => { const lang = await getLang(page); @@ -140,14 +114,6 @@ test.describe("Can generate JWT examples", () => { const decoderWidget = page.getByTestId(dataTestidDictionary.decoder.id); - const exampleButton = decoderWidget.getByRole("button", { - name: pickersUiDictionary.exampleAlgPicker.label, - }); - - await exampleButton.click(); - - await expect(exampleButton).not.toBeVisible(); - const pickerIndicator = decoderWidget.getByText( pickersUiDictionary.exampleAlgPicker.defaultValue, ); From 47ddaabe703973d6486cd04543be1f7c0eb862cb Mon Sep 17 00:00:00 2001 From: Javier Tinoco <213990346+javiert-okta@users.noreply.github.com> Date: Wed, 8 Oct 2025 17:01:16 -0500 Subject: [PATCH 2/7] add aria-label to card toolbar button --- .../card-toolbar-button/card-toolbar-button.component.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/features/common/components/card-toolbar-button/card-toolbar-button.component.tsx b/src/features/common/components/card-toolbar-button/card-toolbar-button.component.tsx index c6de263b..5742102d 100644 --- a/src/features/common/components/card-toolbar-button/card-toolbar-button.component.tsx +++ b/src/features/common/components/card-toolbar-button/card-toolbar-button.component.tsx @@ -36,6 +36,7 @@ export const CardToolbarButtonComponent: React.FC< MonoFont.className )} data-style="compact" + aria-label={tooltipText} > {children} From 4a359983243536aaee3e667ae25f2ce7541f831f Mon Sep 17 00:00:00 2001 From: Javier Tinoco <213990346+javiert-okta@users.noreply.github.com> Date: Wed, 8 Oct 2025 17:01:32 -0500 Subject: [PATCH 3/7] fix jsx syntax on icons components --- src/app/apple-icon.tsx | 40 +++++++++---------- src/app/icon.tsx | 40 +++++++++---------- .../assets/arrow-head-icon.component.tsx | 6 +-- .../common/assets/download-icon.component.tsx | 12 +++--- .../ribbon/assets/dark-icon.component.tsx | 4 +- .../ribbon/assets/light-icon.component.tsx | 6 +-- .../ribbon/assets/system-icon.component.tsx | 12 +++--- 7 files changed, 60 insertions(+), 60 deletions(-) diff --git a/src/app/apple-icon.tsx b/src/app/apple-icon.tsx index f594f156..85294345 100644 --- a/src/app/apple-icon.tsx +++ b/src/app/apple-icon.tsx @@ -86,62 +86,62 @@ export default function Icon({ id }: { id: string }) { xmlns="http://www.w3.org/2000/svg" > diff --git a/src/app/icon.tsx b/src/app/icon.tsx index 61cc18cc..1b981273 100644 --- a/src/app/icon.tsx +++ b/src/app/icon.tsx @@ -66,62 +66,62 @@ export default function Icon({ id }: { id: string }) { xmlns="http://www.w3.org/2000/svg" > diff --git a/src/features/common/assets/arrow-head-icon.component.tsx b/src/features/common/assets/arrow-head-icon.component.tsx index a0a25859..0910b453 100644 --- a/src/features/common/assets/arrow-head-icon.component.tsx +++ b/src/features/common/assets/arrow-head-icon.component.tsx @@ -12,9 +12,9 @@ export const ArrowHeadIconComponent: React.FC = () => { ); diff --git a/src/features/common/assets/download-icon.component.tsx b/src/features/common/assets/download-icon.component.tsx index c7eb7ec2..f401a279 100644 --- a/src/features/common/assets/download-icon.component.tsx +++ b/src/features/common/assets/download-icon.component.tsx @@ -12,16 +12,16 @@ export const DownloadIconComponent: React.FC = () => { ); diff --git a/src/features/common/components/bars/ribbon/assets/dark-icon.component.tsx b/src/features/common/components/bars/ribbon/assets/dark-icon.component.tsx index 7607d241..3961a806 100644 --- a/src/features/common/components/bars/ribbon/assets/dark-icon.component.tsx +++ b/src/features/common/components/bars/ribbon/assets/dark-icon.component.tsx @@ -12,8 +12,8 @@ export const DarkIconComponent: React.FC = () => { ); diff --git a/src/features/common/components/bars/ribbon/assets/light-icon.component.tsx b/src/features/common/components/bars/ribbon/assets/light-icon.component.tsx index d1f78402..05f3eebe 100644 --- a/src/features/common/components/bars/ribbon/assets/light-icon.component.tsx +++ b/src/features/common/components/bars/ribbon/assets/light-icon.component.tsx @@ -16,11 +16,11 @@ export const LightIconComponent: React.FC = () => { height="6" rx="3" stroke="currentColor" - stroke-width="1.5" + strokeWidth="1.5" > diff --git a/src/features/common/components/bars/ribbon/assets/system-icon.component.tsx b/src/features/common/components/bars/ribbon/assets/system-icon.component.tsx index dbc0ed77..17d5c982 100644 --- a/src/features/common/components/bars/ribbon/assets/system-icon.component.tsx +++ b/src/features/common/components/bars/ribbon/assets/system-icon.component.tsx @@ -12,7 +12,7 @@ export const SystemIconComponent: React.FC = () => { { width="8" height="5" stroke="currentColor" - stroke-width="1.5" - stroke-linejoin="round" + strokeWidth="1.5" + strokeLinejoin="round" > { ); From 17221cf1a3153a80be7911895a2c45249201bb1b Mon Sep 17 00:00:00 2001 From: Javier Tinoco <213990346+javiert-okta@users.noreply.github.com> Date: Tue, 21 Oct 2025 08:34:35 -0500 Subject: [PATCH 4/7] add data test id to encoding format switch --- .../encoding-format-toggle-switch.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/features/decoder/components/encoding-format-toggle-swith/encoding-format-toggle-switch.tsx b/src/features/decoder/components/encoding-format-toggle-swith/encoding-format-toggle-switch.tsx index bd034ce4..e9a56160 100644 --- a/src/features/decoder/components/encoding-format-toggle-swith/encoding-format-toggle-switch.tsx +++ b/src/features/decoder/components/encoding-format-toggle-swith/encoding-format-toggle-switch.tsx @@ -6,6 +6,7 @@ import { getPickersUiDictionary } from "@/features/localization/services/ui-lang import { Switch } from "react-aria-components"; import clsx from "clsx"; import { useEncoderStore } from "@/features/encoder/services/encoder.store"; +import { dataTestidDictionary } from "@/libs/testing/data-testid.dictionary"; interface EncodingFormatToggleSwitchComponentProps { languageCode: string; @@ -45,7 +46,10 @@ export const EncodingFormatToggleSwitchComponent: React.FC<
Base64URL Encoded?
-