Skip to content

Conversation

@kevinliLD
Copy link

Give additional instructions for those wishing to see Live Events when testing with the sample application

Give additional instructions for those wishing to see Live Events when testing with the sample application
@kevinliLD kevinliLD marked this pull request as draft April 3, 2023 18:53
@kevinliLD kevinliLD marked this pull request as ready for review April 3, 2023 18:53
Copy link
Contributor

@louis-launchdarkly louis-launchdarkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself is good, just checking do we need to add a bit more.

```java
LDConfig config = new LDConfig.Builder()
.events(Components.sendEvents())
.build();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your testing, do you need to wait before quitting for the events to show up, or does this just work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this and the event shows without further need for flush or delayed quitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants