ot_spi_device: Fix regression on the spi_flash
#267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not only: it triggers immediately without accessing a single TPM register. As the code that checks of if TPM is enabled reads the wrong register, the TPM code interprets data from another register as TPM being activated... |
The bug was caused by the TPM using the flash register bank for tpm. Signed-off-by: Douglas Reis <doreis@lowrisc.org>
|
Thanks for explaining. I changed the commit message. |
AlexJones0
approved these changes
Oct 30, 2025
|
nit pick: You need to reformat the PR title |
AlexJones0
changed the title
ot_spi_device: Fix regression on the spi_flash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was caused by the TPM using the flash register bank for tpm.
It would only manifest when the flash mode is used with tpm enabled.fix #266