ACP2E-1946: Move PHPCompatibility/PHPCompatibility sniffs into separate namespace

Author: bubasuma

Magento2/Helpers/Assert.php

@@ -17,7 +17,7 @@
 class Assert
 {
     /**
-     * Checks whether the function call is a built-in function call.
+     * Checks whether it is a built-in function call.
      *
      * @param File $phpcsFile
      * @param int $stackPtr
@@ -35,17 +35,19 @@ public static function isBuiltinFunctionCall(File $phpcsFile, int $stackPtr): bo
         }
 
         $prevPtr = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($stackPtr - 1), null, true);
-        $ignorePrevToken = [\T_NEW => true] + Collections::objectOperators();
-        if (isset($ignorePrevToken[$tokens[$prevPtr]['code']])) {
-            return false;
-        }
-
-        if ($tokens[$prevPtr]['code'] === \T_NS_SEPARATOR) {
-            $prevPrevToken = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($prevPtr - 1), null, true);
-            if ($tokens[$prevPrevToken]['code'] === \T_STRING || $tokens[$prevPrevToken]['code'] === \T_NAMESPACE
+        if ($prevPtr !== false) {
+            if (isset(Collections::objectOperators()[$tokens[$prevPtr]['code']])
+                || $tokens[$prevPtr]['code'] === \T_NEW
             ) {
                 return false;
             }
+
+            if ($tokens[$prevPtr]['code'] === \T_NS_SEPARATOR) {
+                $prevPrevPr = $phpcsFile->findPrevious(Tokens::$emptyTokens, ($prevPtr - 1), null, true);
+                if ($prevPrevPr !== false && \in_array($tokens[$prevPrevPr]['code'], [\T_STRING, \T_NAMESPACE], true)) {
+                    return false;
+                }
+            }
         }
 
         return true;

Magento2/Tests/PHPCompatibility/RemovedFunctionsUnitTest.82.inc

@@ -1,4 +1,4 @@
 <?php
 $var = 'hello world';
 utf8_encode($var);
-utf8_decode($var);
+utf8_decode($var);