fix: bad auth error (#178)

Author: fmenezes

src/logger.ts

@@ -12,6 +12,7 @@ export const LogId = {
 
     atlasCheckCredentials: mongoLogId(1_001_001),
     atlasDeleteDatabaseUserFailure: mongoLogId(1_001_002),
+    atlasConnectFailure: mongoLogId(1_001_003),
 
     telemetryDisabled: mongoLogId(1_002_001),
     telemetryEmitFailure: mongoLogId(1_002_002),

src/session.ts

@@ -69,25 +69,24 @@ export class Session extends EventEmitter<{
             this.emit("disconnect");
             return;
         }
-        try {
-            await this.apiClient.deleteDatabaseUser({
+        void this.apiClient
+            .deleteDatabaseUser({
                 params: {
                     path: {
                         groupId: this.connectedAtlasCluster.projectId,
                         username: this.connectedAtlasCluster.username,
                         databaseName: "admin",
                     },
                 },
+            })
+            .catch((err: unknown) => {
+                const error = err instanceof Error ? err : new Error(String(err));
+                logger.error(
+                    LogId.atlasDeleteDatabaseUserFailure,
+                    "atlas-connect-cluster",
+                    `Error deleting previous database user: ${error.message}`
+                );
             });
-        } catch (err: unknown) {
-            const error = err instanceof Error ? err : new Error(String(err));
-
-            logger.error(
-                LogId.atlasDeleteDatabaseUserFailure,
-                "atlas-connect-cluster",
-                `Error deleting previous database user: ${error.message}`
-            );
-        }
         this.connectedAtlasCluster = undefined;
 
         this.emit("disconnect");

src/tools/atlas/metadata/connectCluster.ts

@@ -4,6 +4,7 @@ import { AtlasToolBase } from "../atlasTool.js";
 import { ToolArgs, OperationType } from "../../tool.js";
 import { randomBytes } from "crypto";
 import { promisify } from "util";
+import logger, { LogId } from "../../../logger.js";
 
 const EXPIRY_MS = 1000 * 60 * 60 * 12; // 12 hours
 
@@ -15,6 +16,10 @@ async function generateSecurePassword(): Promise<string> {
     return pass;
 }
 
+function sleep(ms: number): Promise<void> {
+    return new Promise((resolve) => setTimeout(resolve, ms));
+}
+
 export class ConnectClusterTool extends AtlasToolBase {
     protected name = "atlas-connect-cluster";
     protected description = "Connect to MongoDB Atlas cluster";
@@ -100,7 +105,31 @@ export class ConnectClusterTool extends AtlasToolBase {
         cn.searchParams.set("authSource", "admin");
         const connectionString = cn.toString();
 
-        await this.session.connectToMongoDB(connectionString, this.config.connectOptions);
+        let lastError: Error | undefined = undefined;
+
+        for (let i = 0; i < 20; i++) {
+            try {
+                await this.session.connectToMongoDB(connectionString, this.config.connectOptions);
+                lastError = undefined;
+                break;
+            } catch (err: unknown) {
+                const error = err instanceof Error ? err : new Error(String(err));
+
+                lastError = error;
+
+                logger.debug(
+                    LogId.atlasConnectFailure,
+                    "atlas-connect-cluster",
+                    `error connecting to cluster: ${error.message}`
+                );
+
+                await sleep(500); // wait for 500ms before retrying
+            }
+        }
+
+        if (lastError) {
+            throw lastError;
+        }
 
         return {
             content: [

src/tools/tool.ts

@@ -126,9 +126,9 @@ export abstract class ToolBase {
                 {
                     type: "text",
                     text: `Error running ${this.name}: ${error instanceof Error ? error.message : String(error)}`,
-                    isError: true,
                 },
             ],
+            isError: true,
         };
     }