Replace _get_parameter_node with get_node

Author: HippocampusGirl

nipype/pipeline/engine/workflows.py

@@ -834,33 +834,6 @@ def _check_is_already_connected(workflow, node, attrname):
 
         return True
 
-    def _get_parameter_node(self, parameter, subtype="in"):
-        """Returns the underlying node corresponding to an input or
-        output parameter
-        """
-        attrlist = parameter.split(".")
-        _ = attrlist.pop()  # take attribute name
-        nodename = attrlist.pop()
-
-        targetworkflow = self
-        while attrlist:
-            workflowname = attrlist.pop(0)
-            workflow = None
-            for node in targetworkflow._graph.nodes():
-                if node.name == workflowname and isinstance(node, Workflow):
-                    workflow = node
-                    break
-            if workflow is None:
-                return
-            targetworkflow = workflow
-
-        for node in targetworkflow._graph.nodes():
-            if node.name == nodename:
-                if isinstance(node, Workflow):
-                    return
-                else:
-                    return node
-
     def _check_outputs(self, parameter):
         return self._has_attr(parameter, subtype="out")
 
@@ -989,7 +962,7 @@ def _generate_flatgraph(self):
                     logger.debug("in: connections-> %s", str(d["connect"]))
                     for cd in deepcopy(d["connect"]):
                         logger.debug("in: %s", str(cd))
-                        dstnode = node._get_parameter_node(cd[1], subtype="in")
+                        dstnode = node.get_node(parameter.rsplit(".", 1)[0])
                         srcnode = u
                         srcout = cd[0]
                         dstin = cd[1].split(".")[-1]
@@ -1009,7 +982,7 @@ def _generate_flatgraph(self):
                             parameter = cd[0][0]
                         else:
                             parameter = cd[0]
-                        srcnode = node._get_parameter_node(parameter, subtype="out")
+                        srcnode = node.get_node(parameter.rsplit(".", 1)[0])
                         if isinstance(cd[0], tuple):
                             srcout = list(cd[0])
                             srcout[0] = parameter.split(".")[-1]