Rename top level optimizelySdk.logger to optimizelySdk.logging (#229)

Author: jordangarcia

packages/optimizely-sdk/lib/index.browser.js

@@ -29,7 +29,7 @@ var MODULE_NAME = 'INDEX';
  * Entry point into the Optimizely Browser SDK
  */
 module.exports = {
-  logger: logger,
+  logging: logger,
   errorHandler: defaultErrorHandler,
   eventDispatcher: defaultEventDispatcher,
   enums: enums,

packages/optimizely-sdk/lib/index.browser.tests.js

@@ -30,7 +30,9 @@ describe('javascript-sdk', function() {
     var requests;
 
     it('should expose logger, errorHandler, eventDispatcher and enums', function() {
-      assert.isDefined(optimizelyFactory.logger);
+      assert.isDefined(optimizelyFactory.logging);
+      assert.isDefined(optimizelyFactory.logging.createLogger);
+      assert.isDefined(optimizelyFactory.logging.createNoOpLogger);
       assert.isDefined(optimizelyFactory.errorHandler);
       assert.isDefined(optimizelyFactory.eventDispatcher);
       assert.isDefined(optimizelyFactory.enums);
@@ -42,7 +44,7 @@ describe('javascript-sdk', function() {
       var silentLogger;
 
       beforeEach(function() {
-        silentLogger = optimizelyFactory.logger.createLogger({
+        silentLogger = optimizelyFactory.logging.createLogger({
           logLevel: optimizelyFactory.enums.LOG_LEVEL.INFO,
           logToConsole: false,
         });
@@ -251,23 +253,23 @@ describe('javascript-sdk', function() {
 
       describe('automatically created logger instances', function() {
         beforeEach(function() {
-          sinon.stub(optimizelyFactory.logger, 'createLogger').callsFake(function() {
+          sinon.stub(optimizelyFactory.logging, 'createLogger').callsFake(function() {
             return {
               log: function() {},
             };
           });
         });
 
         afterEach(function() {
-          optimizelyFactory.logger.createLogger.restore();
+          optimizelyFactory.logging.createLogger.restore();
         });
 
         it('should instantiate the logger with a custom logLevel when provided', function() {
           var optlyInstance = optimizelyFactory.createInstance({
             datafile: testData.getTestProjectConfig(),
             logLevel: optimizelyFactory.enums.LOG_LEVEL.ERROR,
           });
-          var foundCall = find(optimizelyFactory.logger.createLogger.getCalls(), function(call) {
+          var foundCall = find(optimizelyFactory.logging.createLogger.getCalls(), function(call) {
             return call.returned(sinon.match.same(optlyInstance.logger));
           });
           assert.strictEqual(foundCall.args[0].logLevel, optimizelyFactory.enums.LOG_LEVEL.ERROR);
@@ -277,7 +279,7 @@ describe('javascript-sdk', function() {
           var optlyInstance = optimizelyFactory.createInstance({
             datafile: testData.getTestProjectConfig(),
           });
-          var foundCall = find(optimizelyFactory.logger.createLogger.getCalls(), function(call) {
+          var foundCall = find(optimizelyFactory.logging.createLogger.getCalls(), function(call) {
             return call.returned(sinon.match.same(optlyInstance.logger));
           });
           assert.strictEqual(foundCall.args[0].logLevel, optimizelyFactory.enums.LOG_LEVEL.INFO);

packages/optimizely-sdk/lib/index.node.js

@@ -31,7 +31,7 @@ var MODULE_NAME = 'INDEX';
  * Entry point into the Optimizely Node testing SDK
  */
 module.exports = {
-  logger: logger,
+  logging: logger,
   errorHandler: defaultErrorHandler,
   eventDispatcher: defaultEventDispatcher,
   enums: enums,

packages/optimizely-sdk/lib/index.node.tests.js

@@ -26,7 +26,9 @@ var sinon = require('sinon');
 describe('optimizelyFactory', function() {
   describe('APIs', function() {
     it('should expose logger, errorHandler, eventDispatcher and enums', function() {
-      assert.isDefined(optimizelyFactory.logger);
+      assert.isDefined(optimizelyFactory.logging);
+      assert.isDefined(optimizelyFactory.logging.createLogger);
+      assert.isDefined(optimizelyFactory.logging.createNoOpLogger);
       assert.isDefined(optimizelyFactory.errorHandler);
       assert.isDefined(optimizelyFactory.eventDispatcher);
       assert.isDefined(optimizelyFactory.enums);