[GR-65462] Implement faulthandler.dump_traceback_later

PullRequest: graalpython/3821

Author: msimacek

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_faulthandler.txt

@@ -4,4 +4,3 @@ test.test_faulthandler.FaultHandlerTests.test_is_enabled @ darwin-arm64,darwin-x
 # Disabled since signaling isn't stable during parallel tests
 !test.test_faulthandler.FaultHandlerTests.test_sigbus
 !test.test_faulthandler.FaultHandlerTests.test_sigill
-test.test_faulthandler.FaultHandlerTests.test_sys_xoptions @ darwin-arm64,darwin-x86_64,linux-aarch64,linux-x86_64,win32-AMD64

graalpython/com.oracle.graal.python.test/src/tests/unittest_tags_bytecode_dsl/test_faulthandler.txt

@@ -1,4 +1,3 @@
 test.test_faulthandler.FaultHandlerTests.test_cancel_later_without_dump_traceback_later @ linux-x86_64
 test.test_faulthandler.FaultHandlerTests.test_disable @ linux-x86_64
 test.test_faulthandler.FaultHandlerTests.test_is_enabled @ linux-x86_64
-test.test_faulthandler.FaultHandlerTests.test_sys_xoptions @ linux-x86_64

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/FaulthandlerModuleBuiltins.java

@@ -2559,8 +2559,9 @@ static TruffleString getStrError(int code,
     public abstract static class ExitNode extends PythonUnaryClinicBuiltinNode {
         @TruffleBoundary
         @Specialization
-        Object exit(int status) {
-            PythonContext context = getContext();
+        public static Object exit(int status,
+                        @Bind Node node) {
+            PythonContext context = PythonContext.get(node);
             if (context.getOption(PythonOptions.RunViaLauncher)) {
                 Runtime.getRuntime().halt(status);
             }
@@ -2574,12 +2575,12 @@ protected void perform(Access access) {
                 }
             });
             if (Thread.currentThread() == context.getMainThread()) {
-                throw new PythonExitException(this, status);
+                throw new PythonExitException(node, status);
             } else {
                 context.getEnv().submitThreadLocal(new Thread[]{context.getMainThread()}, new ThreadLocalAction(true, false) {
                     @Override
                     protected void perform(Access access) {
-                        throw new PythonExitException(ExitNode.this, status);
+                        throw new PythonExitException(node, status);
                     }
                 });
             }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/PosixModuleBuiltins.java

@@ -99,7 +99,6 @@
 import com.oracle.graal.python.runtime.PythonContext;
 import com.oracle.graal.python.runtime.exception.PException;
 import com.oracle.graal.python.runtime.object.PFactory;
-import com.oracle.graal.python.util.TimeUtils;
 import com.oracle.truffle.api.dsl.Bind;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
@@ -555,7 +554,7 @@ static long parse(@SuppressWarnings("unused") PNone none) {
         static long parse(VirtualFrame frame, Node inliningTarget, Object seconds,
                         @Cached PyTimeFromObjectNode timeFromObjectNode,
                         @Cached PRaiseNode raiseNode) {
-            long timeout = timeFromObjectNode.execute(frame, inliningTarget, seconds, RoundType.TIMEOUT, TimeUtils.SEC_TO_NS);
+            long timeout = timeFromObjectNode.fromSeconds(frame, inliningTarget, seconds, RoundType.TIMEOUT);
             if (timeout < 0) {
                 throw raiseNode.raise(inliningTarget, ValueError, ErrorMessages.TIMEOUT_VALUE_OUT_OF_RANGE);
             }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/socket/SocketNodes.java

@@ -53,6 +53,7 @@
 import com.oracle.graal.python.runtime.exception.PException;
 import com.oracle.graal.python.util.OverflowException;
 import com.oracle.graal.python.util.PythonUtils;
+import com.oracle.graal.python.util.TimeUtils;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
 import com.oracle.truffle.api.dsl.Cached.Shared;
@@ -80,10 +81,14 @@ public enum RoundType {
 
     public abstract long execute(VirtualFrame frame, Node inliningTarget, Object obj, RoundType round, long unitToNs);
 
+    // Like _PyTime_FromSecondsObject
+    public final long fromSeconds(VirtualFrame frame, Node inliningTarget, Object obj, RoundType round) {
+        return execute(frame, inliningTarget, obj, round, TimeUtils.SEC_TO_NS);
+    }
+
     @Specialization
     static long doDouble(Node inliningTarget, double d, RoundType round, long unitToNs,
                     @Shared @Cached PRaiseNode raiseNode) {
-        // Implements _PyTime_FromDouble, rounding mode (HALF_UP) is hard-coded for now
         if (Double.isNaN(d)) {
             throw raiseNode.raise(inliningTarget, ValueError, INVALID_VALUE_NAN);
         }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/lib/PyTimeFromObjectNode.java

@@ -711,6 +711,9 @@ public abstract class ErrorMessages {
     public static final TruffleString SIZE_SHOULD_NOT_BE_NEGATIVE = tsLiteral("size should not be negative");
     public static final TruffleString STRING_INDEX_OUT_OF_RANGE = tsLiteral("IndexError: string index out of range");
     public static final TruffleString STRING_INDICES_MUST_BE_INTEGERS_NOT_P = tsLiteral("string indices must be integers, not '%p'");
+    public static final TruffleString SYS_STDERR_IS_NONE = tsLiteral("sys.stderr is None");
+    public static final TruffleString FILE_IS_NOT_A_VALID_FILE_DESCRIPTOR = tsLiteral("file is not a valid file descriptor");
+    public static final TruffleString FILE_FILENO_IS_NOT_A_VALID_FILE_DESCRIPTOR = tsLiteral("file.fileno() is not a valid file descriptor");
     public static final TruffleString SUBSTRING_NOT_FOUND = tsLiteral("substring not found");
     public static final TruffleString SUBSECTION_NOT_FOUND = tsLiteral("subsection not found");
     public static final TruffleString SUB_VIEWS_NOT_IMPLEMENTED = tsLiteral("sub-views are not implemented");

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/nodes/ErrorMessages.java

@@ -68,17 +68,17 @@
 import com.oracle.graal.python.nodes.function.BuiltinFunctionRootNode;
 import com.oracle.graal.python.nodes.object.GetClassNode;
 import com.oracle.graal.python.runtime.PythonContext;
-import com.oracle.graal.python.runtime.object.PFactory;
 import com.oracle.graal.python.runtime.PythonOptions;
+import com.oracle.graal.python.runtime.object.PFactory;
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.RootCallTarget;
 import com.oracle.truffle.api.Truffle;
 import com.oracle.truffle.api.TruffleStackTrace;
 import com.oracle.truffle.api.TruffleStackTraceElement;
-import com.oracle.truffle.api.exception.AbstractTruffleException;
 import com.oracle.truffle.api.bytecode.BytecodeNode;
+import com.oracle.truffle.api.exception.AbstractTruffleException;
 import com.oracle.truffle.api.frame.Frame;
 import com.oracle.truffle.api.frame.FrameInstance;
 import com.oracle.truffle.api.frame.FrameInstanceVisitor;
@@ -171,17 +171,7 @@ public static void printPythonLikeStackTrace(PythonContext context, Throwable e)
 
     @TruffleBoundary
     public static void printPythonLikeStackTrace(PrintWriter p, Throwable e) {
-        List<TruffleStackTraceElement> stackTrace = TruffleStackTrace.getStackTrace(e);
-        if (stackTrace != null) {
-            ArrayList<String> stack = new ArrayList<>();
-            for (TruffleStackTraceElement frame : stackTrace) {
-                Node location = frame.getLocation();
-                RootNode rootNode = frame.getTarget().getRootNode();
-                int lineno = getLineno(frame.getFrame(), location, null);
-                appendStackLine(stack, location, rootNode, false, lineno);
-            }
-            printStack(p, stack);
-        }
+        printPythonLikeStackTraceNoMessage(p, e);
         InteropLibrary lib = InteropLibrary.getUncached();
         if (lib.isException(e) && lib.hasExceptionMessage(lib)) {
             try {
@@ -195,6 +185,21 @@ public static void printPythonLikeStackTrace(PrintWriter p, Throwable e) {
         }
     }
 
+    @TruffleBoundary
+    public static void printPythonLikeStackTraceNoMessage(PrintWriter p, Throwable e) {
+        List<TruffleStackTraceElement> stackTrace = TruffleStackTrace.getStackTrace(e);
+        if (stackTrace != null) {
+            ArrayList<String> stack = new ArrayList<>();
+            for (TruffleStackTraceElement frame : stackTrace) {
+                Node location = frame.getLocation();
+                RootNode rootNode = frame.getTarget().getRootNode();
+                int lineno = getLineno(frame.getFrame(), location, null);
+                appendStackLine(stack, location, rootNode, false, lineno);
+            }
+            printStack(p, stack);
+        }
+    }
+
     private static void appendStackLine(ArrayList<String> stack, Node location, RootNode rootNode, boolean evenWithoutSource, int lineno) {
         if (rootNode instanceof TopLevelExceptionHandler) {
             return;