Made public methods overwritable in new JavaScript layer

Author: Christopher Jones

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## node-oracledb v1.7.1 (1 Mar 2016)
+
+- Made public methods overwritable in new JavaScript layer
+
 ## node-oracledb v1.7.0 (29 Feb 2016)
 
 - Added a JavaScript wrapper around the C++ API to allow for easier

README.md

@@ -1,4 +1,4 @@
-# node-oracledb version 1.7
+# node-oracledb version 1.7.1
 
 ## <a name="about"></a> About node-oracledb
 

doc/api.md

@@ -1,4 +1,4 @@
-# node-oracledb 1.7: Documentation for the Oracle Database Node.js Add-on
+# node-oracledb 1.8: Documentation for the Oracle Database Node.js Add-on
 
 *Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.*
 

lib/connection.js

@@ -124,35 +124,40 @@ function extend(conn, pool) {
       },
       execute: {
         value: execute,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _commit: {
         value: conn.commit
       },
       commit: {
         value: commit,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _rollback: {
         value: conn.rollback
       },
       rollback: {
         value: rollback,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _release: {
         value: conn.release
       },
       release: {
         value: release,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _break: {
         value: conn.break
       },
       break: {
         value: module.break,
-        enumerable: true
+        enumerable: true,
+        writable: true
       }
     }
   );

lib/oracledb.js

@@ -170,14 +170,16 @@ function extend(oracledb) {
       },
       createPool: {
         value: createPool,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _getConnection: {
         value: oracledb.getConnection
       },
       getConnection: {
         value: getConnection,
-        enumerable: true
+        enumerable: true,
+        writable: true
       }
     }
   );

lib/pool.js

@@ -367,14 +367,16 @@ function extend(pool, poolAttrs, oracledb) {
       },
       getConnection: {
         value: getConnection,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _terminate: {
         value: pool.terminate
       },
       terminate: {
         value: terminate,
-        enumerable: true
+        enumerable: true,
+        writable: true
       }
     }
   );

lib/resultset.js

@@ -52,21 +52,24 @@ function extend(resultSet) {
       },
       close: {
         value: close,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _getRow: {
         value: resultSet.getRow
       },
       getRow: {
         value: getRow,
-        enumerable: true
+        enumerable: true,
+        writable: true
       },
       _getRows: {
         value: resultSet.getRows
       },
       getRows: {
         value: getRows,
-        enumerable: true
+        enumerable: true,
+        writable: true
       }
     }
   );

package.json

@@ -1,6 +1,6 @@
 {
   "name": "oracledb",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "description": "Oracle Database driver by Oracle Corp.",
   "license": "Apache-2.0",
   "homepage": "http://www.oracle.com/technetwork/database/database-technologies/scripting-languages/node_js/",

src/njs/src/njsOracle.h

@@ -70,7 +70,7 @@ using namespace v8;
 /* Keep the version in sync with package.json */
 #define NJS_NODE_ORACLEDB_MAJOR       1
 #define NJS_NODE_ORACLEDB_MINOR       7
-#define NJS_NODE_ORACLEDB_PATCH       0
+#define NJS_NODE_ORACLEDB_PATCH       1
 
 /* Used for Oracledb.version */
 #define NJS_NODE_ORACLEDB_VERSION   ( (NJS_NODE_ORACLEDB_MAJOR * 10000) + \

test/list.txt

@@ -596,3 +596,10 @@
 
 65. uninitializedLob.js
     65.1 an uninitialized Lob is returned from a PL/SQL block
+
+66. writableProperties.js
+    66.1 allows overwriting of public methods on the oracledb instance
+    66.2 allows overwriting of public methods on pool instances
+    66.3 allows overwriting of public methods on connection instances
+    66.4 allows overwriting of public methods on resultset instances
+    66.5 allows overwriting of public methods on lob instances