Please support --fail-if-no-pacts-found in verifier configuration

[jvmlet]

Please support --fail-if-no-pacts-found in verifier configuration

[mkokho]

Agree, useful feature. It is hard to make Providers run contract test in new environment when no consumers exist yet

Support was added in pact-js in 2022: pact-foundation/pact-js#941

[mkokho]

possible workaround

/// <summary>
        /// Send a request to the Pact Broker to check if pacts exist for the given filters.
        /// </summary>
        /// <returns>true if at least one pact is returned for the given filters</returns>
        private async Task<bool> PactsForVerificationExist(Uri pactBrokerUri, string providerName,
            List<ConsumerVersionSelector> pactsSelectors)
        {
            var jsonSettings = new JsonSerializerSettings
            {
                DefaultValueHandling = DefaultValueHandling.Ignore,
                NullValueHandling = NullValueHandling.Ignore,
                ContractResolver = new DefaultContractResolver { NamingStrategy = new CamelCaseNamingStrategy() }
            };

            var payload = new Dictionary<dynamic, dynamic>
            {
                { "consumerVersionSelectors", pactsSelectors },
                { "includePendingStatus", true },
                { "includeWipPactsSince", "2023-06-01" }
            };
            var payloadAsJson = JsonConvert.SerializeObject(payload, jsonSettings);
            var data = new StringContent(payloadAsJson, Encoding.UTF8, "application/json");

            var forVerificationUri = new Uri(pactBrokerUri + $"/providers/{providerName}/for-verification");
            var response = await _httpClient.PostAsync(pactBrokerUri, data);
            var result = await response.Content.ReadAsStringAsync();

            // return true if at least one pact is returned
            return result.Contains(providerName);
        }

[mefellows]

I imagine it's a pretty straightforward addition - would you be open to creating a PR?

[ekarnialiuk]

Hey, just a friendly reminder. Could you please implement this feature? It's quite inconvenient to verify interactions when there are numerous services, and the contracts are not ready. This is especially unpleasant to realize when other languages ​​have such a setting to disable.

Looking forward to your response about this issue, thanks!

[YOU54F]

Why not fork the project, implement the feature and propose a pull request?

It was introduced by an external contributor in the linked pull request against pact-js.

[levanoz]

Hi, I've create PR regarding this feature.
@mefellows could you please review PR: #541

[mefellows]

Hi @levanoz - thanks for the PR!

I'll take a look, but the maintainer of this repo gets the ultimate call (I'm also no C# expert!)

[adamrodger]

I'm back from vacation now so I'll try to take a look tomorrow 👍