diff --git a/pglet/pglet.py b/pglet/pglet.py index c8aa1dc..fa62504 100644 --- a/pglet/pglet.py +++ b/pglet/pglet.py @@ -235,7 +235,26 @@ def _download_pglet(): zip_arch.extractall(pglet_bin) else: with tarfile.open(temp_arch, "r:gz") as tar_arch: - tar_arch.extractall(pglet_bin) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_arch, pglet_bin) finally: os.remove(temp_arch) return str(pglet_path)