Error identifiers

Author: ondrejmirtes

src/Rules/Doctrine/ORM/DqlRule.php

@@ -78,6 +78,7 @@ public function processNode(Node $node, Scope $scope): array
 				$query->getAST();
 			} catch (QueryException $e) {
 				$messages[] = RuleErrorBuilder::message(sprintf('DQL: %s', $e->getMessage()))
+					->identifier('doctrine.dql')
 					->build();
 			} catch (AssertionError $e) {
 				continue;

src/Rules/Doctrine/ORM/EntityColumnRule.php

@@ -107,7 +107,7 @@ public function processNode(Node $node, Scope $scope): array
 					$className,
 					$propertyName,
 					$fieldMapping['type']
-				))->build(),
+				))->identifier('doctrine.descriptorNotFound')->build(),
 			] : [];
 		}
 
@@ -128,7 +128,7 @@ public function processNode(Node $node, Scope $scope): array
 							$backedEnumType->describe(VerbosityLevel::typeOnly()),
 							$enumReflection->getDisplayName(),
 							$writableToDatabaseType->describe(VerbosityLevel::typeOnly())
-						))->build();
+						))->identifier('doctrine.enumType')->build();
 					}
 				}
 			}
@@ -179,7 +179,7 @@ public function processNode(Node $node, Scope $scope): array
 				$propertyName,
 				$writableToPropertyType->describe(VerbosityLevel::getRecommendedLevelByType($propertyTransformedType, $writableToPropertyType)),
 				$propertyType->describe(VerbosityLevel::getRecommendedLevelByType($propertyTransformedType, $writableToPropertyType))
-			))->build();
+			))->identifier('doctrine.columnType')->build();
 		}
 
 		if (
@@ -195,7 +195,7 @@ public function processNode(Node $node, Scope $scope): array
 				$propertyName,
 				$propertyTransformedType->describe(VerbosityLevel::getRecommendedLevelByType($writableToDatabaseType, $propertyType)),
 				$writableToDatabaseType->describe(VerbosityLevel::getRecommendedLevelByType($writableToDatabaseType, $propertyType))
-			))->build();
+			))->identifier('doctrine.columnType')->build();
 		}
 		return $errors;
 	}

src/Rules/Doctrine/ORM/EntityConstructorNotFinalRule.php

@@ -58,7 +58,7 @@ public function processNode(Node $node, Scope $scope): array
 			RuleErrorBuilder::message(sprintf(
 				'Constructor of class %s is final which can cause problems with proxies.',
 				$classReflection->getDisplayName()
-			))->build(),
+			))->identifier('doctrine.finalConstructor')->build(),
 		];
 	}
 

src/Rules/Doctrine/ORM/EntityMappingExceptionRule.php

@@ -60,6 +60,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [
 				RuleErrorBuilder::message($e->getMessage())
 					->nonIgnorable()
+					->identifier('doctrine.mapping')
 					->build(),
 			];
 		}

src/Rules/Doctrine/ORM/EntityNotFinalRule.php

@@ -53,7 +53,7 @@ public function processNode(Node $node, Scope $scope): array
 			RuleErrorBuilder::message(sprintf(
 				'Entity class %s is final which can cause problems with proxies.',
 				$classReflection->getDisplayName()
-			))->build(),
+			))->identifier('doctrine.finalEntity')->build(),
 		];
 	}
 

src/Rules/Doctrine/ORM/EntityRelationRule.php

@@ -135,7 +135,7 @@ public function processNode(Node $node, Scope $scope): array
 					$propertyName,
 					$columnType->describe(VerbosityLevel::typeOnly()),
 					$propertyType->describe(VerbosityLevel::typeOnly())
-				))->build();
+				))->identifier('doctrine.associationType')->build();
 			}
 			if (
 				!$columnType->isSuperTypeOf(
@@ -150,7 +150,7 @@ public function processNode(Node $node, Scope $scope): array
 					$propertyName,
 					$propertyType->describe(VerbosityLevel::typeOnly()),
 					$columnType->describe(VerbosityLevel::typeOnly())
-				))->build();
+				))->identifier('doctrine.associationType')->build();
 			}
 		}
 

src/Rules/Doctrine/ORM/QueryBuilderDqlRule.php

@@ -64,6 +64,7 @@ public function processNode(Node $node, Scope $scope): array
 			) {
 				return [
 					RuleErrorBuilder::message('Could not analyse QueryBuilder with unknown beginning.')
+						->identifier('doctrine.queryBuilderDynamic')
 						->build(),
 				];
 			}
@@ -76,6 +77,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [
 				RuleErrorBuilder::message(sprintf('Internal error: %s', $e->getMessage()))
 					->nonIgnorable()
+					->identifier('doctrine.internalError')
 					->build(),
 			];
 		}
@@ -85,6 +87,7 @@ public function processNode(Node $node, Scope $scope): array
 			if ($this->reportDynamicQueryBuilders) {
 				return [
 					RuleErrorBuilder::message('Could not analyse QueryBuilder with dynamic arguments.')
+						->identifier('doctrine.queryBuilderDynamicArgument')
 						->build(),
 				];
 			}
@@ -115,6 +118,7 @@ public function processNode(Node $node, Scope $scope): array
 				}
 
 				$messages[] = RuleErrorBuilder::message($message)
+					->identifier('doctrine.dql')
 					->build();
 			} catch (AssertionError $e) {
 				continue;

src/Rules/Doctrine/ORM/RepositoryMethodCallRule.php

@@ -83,7 +83,7 @@ public function processNode(Node $node, Scope $scope): array
 						$methodName,
 						$entityClassNames[0],
 						$fieldName->getValue()
-					))->build();
+					))->identifier(sprintf('doctrine.%sArgument', $methodName))->build();
 				}
 			}
 		}