Allow for final embeddable class

Author: akondas

src/Rules/Doctrine/ORM/EntityNotFinalRule.php

@@ -43,6 +43,11 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		$metadata = $this->objectMetadataResolver->getClassMetadata($classReflection->getName());
+		if ($metadata !== null && $metadata->isEmbeddedClass === true) {
+			return [];
+		}
+
 		return [sprintf(
 			'Entity class %s is final which can cause problems with proxies.',
 			$classReflection->getDisplayName()

tests/Rules/Doctrine/ORM/EntityNotFinalRuleTest.php

@@ -72,6 +72,16 @@ public function ruleProvider(): Iterator
 			__DIR__ . '/data/MyEntity.php',
 			[],
 		];
+
+		yield 'final embeddable' => [
+			__DIR__ . '/data/FinalEmbeddable.php',
+			[],
+		];
+
+		yield 'non final embeddable' => [
+			__DIR__ . '/data/MyEmbeddable.php',
+			[],
+		];
 	}
 
 }

tests/Rules/Doctrine/ORM/data/FinalEmbeddable.php

@@ -0,0 +1,21 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Embeddable()
+ */
+final class FinalEmbeddable
+{
+	/**
+	 * @ORM\Id()
+	 * @ORM\GeneratedValue()
+	 * @ORM\Column(type="integer")
+	 *
+	 * @var int
+	 */
+	private $id;
+
+}

tests/Rules/Doctrine/ORM/data/MyEmbeddable.php

@@ -0,0 +1,17 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Embeddable()
+ */
+class MyEmbeddable
+{
+	/**
+	 * @var string
+	 * @ORM\Column(type="string")
+	 */
+	private $title;
+}