Allow boolean in Command->addOption default value

Author: codeTom

src/Rules/Symfony/InvalidOptionDefaultValueRule.php

@@ -8,14 +8,13 @@
 use PHPStan\Rules\Rule;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Type\ArrayType;
-use PHPStan\Type\Constant\ConstantBooleanType;
+use PHPStan\Type\BooleanType;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\NullType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\StringType;
-use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\UnionType;
 use PHPStan\Type\VerbosityLevel;
@@ -70,10 +69,7 @@ public function processNode(Node $node, Scope $scope): array
 
 		// not an array
 		if (($mode & 8) !== 8) {
-			$checkType = new UnionType([new StringType(), new IntegerType(), new NullType()]);
-			if (($mode & 4) === 4) { // https://symfony.com/doc/current/console/input.html#options-with-optional-arguments
-				$checkType = TypeCombinator::union($checkType, new ConstantBooleanType(false));
-			}
+			$checkType = new UnionType([new StringType(), new IntegerType(), new NullType(), new BooleanType()]);
 			if (!$checkType->isSuperTypeOf($defaultType)->yes()) {
 				return [sprintf('Parameter #5 $default of method Symfony\Component\Console\Command\Command::addOption() expects %s, %s given.', $checkType->describe(VerbosityLevel::typeOnly()), $defaultType->describe(VerbosityLevel::typeOnly()))];
 			}

tests/Rules/Symfony/ExampleCommand.php

@@ -29,6 +29,7 @@ protected function configure(): void
 		$this->addOption('b', null, InputOption::VALUE_IS_ARRAY | InputOption::VALUE_OPTIONAL, '', [1]);
 		$this->addOption('c', null, InputOption::VALUE_OPTIONAL, '', 1);
 		$this->addOption('d', null, InputOption::VALUE_OPTIONAL, '', false);
+		$this->addOption('f', null, InputOption::VALUE_REQUIRED, '', true);
 
 		/** @var string[] $defaults */
 		$defaults = [];

tests/Rules/Symfony/UndefinedArgumentRuleTest.php

@@ -38,7 +38,7 @@ public function testGetArgument(): void
 			[
 				[
 					'Command "example-rule" does not define argument "undefined".',
-					41,
+					42,
 				],
 			]
 		);

tests/Rules/Symfony/UndefinedOptionRuleTest.php

@@ -38,7 +38,7 @@ public function testGetArgument(): void
 			[
 				[
 					'Command "example-rule" does not define option "bbb".',
-					48,
+					49,
 				],
 			]
 		);