fix: reorder parameters in ConnectionFactoryCustomizer interface (#154)

* fix!: reorder parameters in ConnectionFactoryCustomizer interface and its implementations

* fix!: correct argument order in ConnectionFactoryCustomizer mock setup

---------

Co-authored-by: lugomez <lugomez@bancolombia.com.co>

Author: luisgomez29

docs/docs/migration-guides.md

@@ -16,7 +16,7 @@ sidebar_position: 4
 
 @Bean
 public ConnectionFactoryCustomizer connectionFactoryCustomizer() {
-    return (ConnectionFactoryCustomizer) (asyncProps, connectionFactory) -> {
+    return (connectionFactory, asyncProps) -> {
         connectionFactory.setExceptionHandler(new MyCustomExceptionHandler()); // Optional custom exception handler
         connectionFactory.setCredentialsProvider(new MyCustomCredentialsProvider()); // Optional custom credentials provider
         return connectionFactory;

docs/docs/reactive-commons/configuration_properties/1-rabbitmq.md

@@ -200,7 +200,7 @@ or automatic recovery strategies:
 
 @Bean
 public ConnectionFactoryCustomizer connectionFactoryCustomizer() {
-    return (ConnectionFactoryCustomizer) (asyncProps, connectionFactory) -> {
+    return (connectionFactory, asyncProps) -> {
         connectionFactory.setExceptionHandler(new MyCustomExceptionHandler()); // Optional custom exception handler
         connectionFactory.setCredentialsProvider(new MyCustomCredentialsProvider()); // Optional custom credentials provider
         return connectionFactory;

starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/ConnectionFactoryCustomizer.java

@@ -9,6 +9,6 @@
 @FunctionalInterface
 public interface ConnectionFactoryCustomizer {
 
-    ConnectionFactory customize(AsyncProps asyncProps, ConnectionFactory connectionFactory);
+    ConnectionFactory customize(ConnectionFactory connectionFactory, AsyncProps asyncProps);
 
 }

starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/RabbitMQSetupUtils.java

@@ -94,7 +94,7 @@ public static ConnectionFactoryProvider connectionFactoryProvider(AsyncProps asy
                 map.from(rabbitProperties::determineVirtualHost).whenNonNull().to(newFactory::setVirtualHost);
                 newFactory.useNio();
                 setUpSSL(newFactory, rabbitProperties);
-                return cfCustomizer.customize(props, newFactory);
+                return cfCustomizer.customize(newFactory, props);
             } catch (Exception e) {
                 throw new RuntimeException("Error creating ConnectionFactory: ", e);
             }

starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/starter/impl/common/rabbit/RabbitMQConfig.java

@@ -63,7 +63,7 @@ UnroutableMessageProcessor defaultUnroutableMessageProcessor(UnroutableMessageNo
     @Bean
     @ConditionalOnMissingBean(ConnectionFactoryCustomizer.class)
     public ConnectionFactoryCustomizer defaultConnectionFactoryCustomizer() {
-        return ((asyncProps, connectionFactory) -> connectionFactory);
+        return (connectionFactory, asyncProps) -> connectionFactory;
     }
 
 }

starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/rabbit/RabbitMQBrokerProviderFactoryTest.java

@@ -70,8 +70,8 @@ void shouldReturnCreateDiscardProvider() {
 
     @Test
     void shouldReturnBrokerProvider() {
-        when(cfCustomizer.customize(any(AsyncProps.class), any(ConnectionFactory.class)))
-                .thenAnswer(invocation -> invocation.<ConnectionFactory>getArgument(1));
+        when(cfCustomizer.customize(any(ConnectionFactory.class), any(AsyncProps.class)))
+                .thenAnswer(invocation -> invocation.<ConnectionFactory>getArgument(0));
 
         // Arrange
         AsyncProps props = new AsyncProps();

starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/rabbit/RabbitMQDiscardProviderImplTest.java

@@ -30,8 +30,8 @@ class RabbitMQDiscardProviderImplTest {
 
     @BeforeEach
     void setUp() {
-        when(cfCustomizer.customize(any(AsyncProps.class), any(ConnectionFactory.class)))
-                .thenAnswer(invocation -> invocation.<ConnectionFactory>getArgument(1));
+        when(cfCustomizer.customize(any(ConnectionFactory.class), any(AsyncProps.class)))
+                .thenAnswer(invocation -> invocation.<ConnectionFactory>getArgument(0));
     }
 
     @Test

starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/starter/impl/common/rabbit/RabbitMQConfigTest.java

@@ -135,7 +135,7 @@ void shouldReturnSameConnectionFactoryWhenCustomizing() {
         ConnectionFactory originalFactory = new ConnectionFactory();
         AsyncProps asyncProps = new AsyncProps();
 
-        ConnectionFactory result = customizer.customize(asyncProps, originalFactory);
+        ConnectionFactory result = customizer.customize(originalFactory, asyncProps);
 
         assertThat(result).isSameAs(originalFactory);
     }