Handle all of the ruff errors in tests/

Author: Archmonger

src/reactpy_django/clean.py

@@ -88,7 +88,7 @@ def clean_user_data(verbosity: int = 1):
 
     # Django doesn't support using QuerySets as an argument with cross-database relations.
     if user_model.objects.db != UserDataModel.objects.db:
-        all_user_pks = list(all_user_pks)  # type: ignore
+        all_user_pks = list(all_user_pks)
 
     user_data_objects = UserDataModel.objects.exclude(user_pk__in=all_user_pks)
 

src/reactpy_django/components.py

@@ -155,7 +155,7 @@ def _view_to_component(
     else:
         _request = HttpRequest()
         _request.method = "GET"
-    resolved_view: Callable = import_module(view) if isinstance(view, str) else view  # type: ignore[assignment]
+    resolved_view: Callable = import_module(view) if isinstance(view, str) else view
 
     # Render the view render within a hook
     @hooks.use_effect(

src/reactpy_django/hooks.py

@@ -139,7 +139,7 @@ async def execute_query() -> None:
         try:
             # Run the query
             if asyncio.iscoroutinefunction(query):
-                new_data = await query(**kwargs)  # type: ignore[call-arg]
+                new_data = await query(**kwargs)
             else:
                 new_data = await database_sync_to_async(query, thread_sensitive=thread_sensitive)(**kwargs)
 

src/reactpy_django/models.py

@@ -9,15 +9,15 @@
 class ComponentSession(models.Model):
     """A model for storing component sessions."""
 
-    uuid = models.UUIDField(primary_key=True, editable=False, unique=True)  # type: ignore
-    params = models.BinaryField(editable=False)  # type: ignore
-    last_accessed = models.DateTimeField(auto_now=True)  # type: ignore
+    uuid = models.UUIDField(primary_key=True, editable=False, unique=True)
+    params = models.BinaryField(editable=False)
+    last_accessed = models.DateTimeField(auto_now=True)
 
 
 class Config(models.Model):
     """A singleton model for storing ReactPy configuration."""
 
-    cleaned_at = models.DateTimeField(auto_now_add=True)  # type: ignore
+    cleaned_at = models.DateTimeField(auto_now_add=True)
 
     def save(self, *args, **kwargs):
         """Singleton save method."""
@@ -36,8 +36,8 @@ class UserDataModel(models.Model):
     # We can't store User as a ForeignKey/OneToOneField because it may not be in the same database
     # and Django does not allow cross-database relations. Also, since we can't know the type of the UserModel PK,
     # we store it as a string to normalize.
-    user_pk = models.CharField(max_length=255, unique=True)  # type: ignore
-    data = models.BinaryField(null=True, blank=True)  # type: ignore
+    user_pk = models.CharField(max_length=255, unique=True)
+    data = models.BinaryField(null=True, blank=True)
 
 
 @receiver(pre_delete, sender=get_user_model(), dispatch_uid="reactpy_delete_user_data")

src/reactpy_django/utils.py

@@ -76,7 +76,7 @@ async def render_view(
     """Ingests a Django view (class or function) and returns an HTTP response object."""
     # Convert class-based view to function-based view
     if getattr(view, "as_view", None):
-        view = view.as_view()  # type: ignore[union-attr]
+        view = view.as_view()
 
     # Async function view
     if iscoroutinefunction(view):
@@ -425,7 +425,7 @@ def vdom_or_component_to_string(
     """Converts a VdomDict or component to an HTML string. If a string is provided instead, it will be
     automatically returned."""
     if isinstance(vdom_or_component, dict):
-        return vdom_to_html(vdom_or_component)  # type: ignore
+        return vdom_to_html(vdom_or_component)
 
     if hasattr(vdom_or_component, "render"):
         if not request:

tests/manage.py

@@ -1,5 +1,6 @@
 #!/usr/bin/env python
 """Django's command-line utility for administrative tasks."""
+
 import os
 import sys
 
@@ -11,11 +12,12 @@ def main():
     try:
         from django.core.management import execute_from_command_line
     except ImportError as exc:
-        raise ImportError(
+        msg = (
             "Couldn't import Django. Are you sure it's installed and "
             "available on your PYTHONPATH environment variable? Did you "
             "forget to activate a virtual environment?"
-        ) from exc
+        )
+        raise ImportError(msg) from exc
     execute_from_command_line(sys.argv)
 
 

tests/test_app/__init__.py

@@ -4,13 +4,7 @@
 
 # Make sure the JS is always re-built before running the tests
 js_dir = Path(__file__).parent.parent.parent / "src" / "js"
-static_dir = (
-    Path(__file__).parent.parent.parent
-    / "src"
-    / "reactpy_django"
-    / "static"
-    / "reactpy_django"
-)
+static_dir = Path(__file__).parent.parent.parent / "src" / "reactpy_django" / "static" / "reactpy_django"
 assert subprocess.run(["bun", "install"], cwd=str(js_dir), check=True).returncode == 0
 assert (
     subprocess.run(
@@ -38,22 +32,12 @@ def copy_js_files(source_dir: Path, destination: Path) -> None:
 # Copy PyScript
 copy_js_files(
     js_dir / "node_modules" / "@pyscript" / "core" / "dist",
-    Path(__file__).parent.parent.parent
-    / "src"
-    / "reactpy_django"
-    / "static"
-    / "reactpy_django"
-    / "pyscript",
+    Path(__file__).parent.parent.parent / "src" / "reactpy_django" / "static" / "reactpy_django" / "pyscript",
 )
 
 
 # Copy MorphDOM
 copy_js_files(
     js_dir / "node_modules" / "morphdom" / "dist",
-    Path(__file__).parent.parent.parent
-    / "src"
-    / "reactpy_django"
-    / "static"
-    / "reactpy_django"
-    / "morphdom",
+    Path(__file__).parent.parent.parent / "src" / "reactpy_django" / "static" / "reactpy_django" / "morphdom",
 )

tests/test_app/admin.py

@@ -1,6 +1,7 @@
+# ruff: noqa: RUF012
 from django.contrib import admin
-from reactpy_django.models import ComponentSession, Config, UserDataModel
 
+from reactpy_django.models import ComponentSession, Config, UserDataModel
 from test_app.models import (
     AsyncForiegnChild,
     AsyncRelationalChild,

tests/test_app/asgi.py

@@ -16,11 +16,10 @@
 
 from channels.auth import AuthMiddlewareStack  # noqa: E402
 from channels.routing import ProtocolTypeRouter, URLRouter  # noqa: E402
+
 from reactpy_django import REACTPY_WEBSOCKET_ROUTE  # noqa: E402
 
-application = ProtocolTypeRouter(
-    {
-        "http": http_asgi_app,
-        "websocket": AuthMiddlewareStack(URLRouter([REACTPY_WEBSOCKET_ROUTE])),
-    }
-)
+application = ProtocolTypeRouter({
+    "http": http_asgi_app,
+    "websocket": AuthMiddlewareStack(URLRouter([REACTPY_WEBSOCKET_ROUTE])),
+})

tests/test_app/channel_layers/components.py

@@ -1,4 +1,6 @@
+# ruff: noqa: RUF029
 from reactpy import component, hooks, html
+
 from reactpy_django.hooks import use_channel_layer
 
 
@@ -34,7 +36,7 @@ async def submit_event(event):
 
 
 @component
-def group_receiver(id: int):
+def group_receiver(id_number: int):
     state, set_state = hooks.use_state("None")
 
     async def receiver(message):
@@ -43,8 +45,8 @@ async def receiver(message):
     use_channel_layer(receiver=receiver, group_name="group-messenger")
 
     return html.div(
-        {"id": f"group-receiver-{id}", "data-message": state},
-        f"Group Message Receiver #{id}: {state}",
+        {"id": f"group-receiver-{id_number}", "data-message": state},
+        f"Group Message Receiver #{id_number}: {state}",
     )