-
-
Notifications
You must be signed in to change notification settings - Fork 686
Cleanup gitignore file #41077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Cleanup gitignore file #41077
Conversation
Now that we use meson with a full out-of-tree build, we no longer need to gitignore generated files in the src folder. In fact, it's strongly recommended that those older files should be deleted so that they don't get accidentally picked-up by Python at runtime.
|
Documentation preview for this PR (built with commit 38d96eb; changes) is ready! 🎉 |
| worktree* | ||
| **/worktree* | ||
|
|
||
| # Meson build directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have gitignore files on their own.
|
Someone still on sage-the-distro may want to sanity check this doesn't ignore "too little" things. Maybe @jhpalmieri @culler ? Side note, apparently the There's another issue that on my machine (meson on mamba) src/doc/{doctrees,inventory,latex} aren't gitignored, but not very relevant to this issue. |
|
If I apply this to a previous Sage build, the git repo has a ton of untracked files. With a fresh build of 10.8.beta7 (without building the documentation), a lot of |
|
If I take a fresh clone of the git repo and run |
|
Thanks @jhpalmieri I can confirm that Or, perhaps, they should not be even installed there, they should go directly to |
Add patterns to ignore generated documentation files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's OK now, after testing locally on 2 different machines
|
@jhpalmieri thanks for testing.
This is actually already implemented. The problem is that |
|
Because this is likely to result in untracked files in git repos for some people with existing Sage installations (people who have been incorporating changes to Sage via incremental upgrades and builds), I suggest that when this gets merged, it should get merged into an early beta release. |
sagemathgh-41077: Cleanup gitignore file Now that we use meson with a full out-of-tree build, we no longer need to gitignore generated files in the src folder. In fact, it's strongly recommended that those older files should be deleted so that they don't get accidentally picked-up by Python at runtime. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41077 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Tobias Diez
Now that we use meson with a full out-of-tree build, we no longer need to gitignore generated files in the src folder. In fact, it's strongly recommended that those older files should be deleted so that they don't get accidentally picked-up by Python at runtime.
📝 Checklist
⌛ Dependencies