autofix.ci

[scop]

I'd like us to make use of https://autofix.ci for pull requests. In my experience, it works nicely and reduces unnecessary review roundtrips and human action for trivial changes that are made by tools anyway.

At least shfmt, ruff, update-test-cmd-list, and perltidy would fit in nicely. In theory typos too, but that tends to be more about tweaking false positives these days (so we might want to make it flag changes only as opposed to actually making them).

[akinomyoga]

(so we might want to make it flag changes only as opposed to actually making them).

I've never used autofix.ci, but if we let it commit actual changes, how would the changes be split into commits? For example, if I open a PR with multiple commits, and if autofix.ci adds a single commit fixing all trivial mistakes in the original multiple commits, it would be troublesome to properly split and squash the trivial fixes into the respective commits. If it can flag changes in the form of suggestions in the GitHub review, it would be very nice.

By the way, #1121 might also be related.

[scop]

I don't think it can just flag fixes, and there's no splitting. Sometimes its fixes can be easily squashed away, sometimes not. I'm willing to trade the occasional "autofix.ci changes" commit left behind in exchange for the other usefulness it brings, if nobody wants to tidy up/split the commits manually.

[yedayak]

If we don't end up dropping pre-commit, an alternative to this might be https://pre-commit.ci/

[scop]

I've used it, and it integrates nicely with most pre-commit uses. It disallows network access at runtime though, which makes it not work with certain tools.

Anyway moving away from pre-commit is what I think we should do.