[HTTP 1.x] Add legacy crates to maintain http@0.x support during migration #4372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two new legacy crates (
aws-smithy-legacy-httpandaws-smithy-legacy-http-server) that maintain support forhttp@0.xwhile the codebase transitions to
http@1.x.Background
As part of the HTTP 1.x migration effort (see branch
feature/http-1.x), we're adding support for generating server SDKs that depend onhttp@1.xvia a newhttp-1xcodegen flag. However, we need to maintain backward compatibility withhttp@0.xfor existing users.Why Legacy Crates?
Initially, we attempted to pin dependencies to the last versions that supported
http@0.x. However, this approach failed because:Solution
Creating dedicated legacy crates solves this problem by:
Changes in this PR
aws-smithy-legacy-httpcrate (forked fromaws-smithy-httpwith http@0.x support)aws-smithy-legacy-http-servercrate (forked fromaws-smithy-http-serverwith http@0.x support)rust-runtime/Cargo.tomlto include both legacy crates in the workspaceNote
This PR is split out from the main
http@1.xwork to make it easier for reviewers to evaluate just the legacy crate additions separately from the codegen changes. By default,http@0.xremains the default - thehttp-1xflag must be explicitly enabled to usehttp@1.x.