Fix Z3 bound variable substitution #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2025 23:25
…torTest with more than one bound variable
…are instantiated reversed
|
The Z3 issue with the solution provided by NikolajBjorner can be found here: Z3Prover/z3#7970 |
added 2 commits
October 16, 2025 09:46
…f BitvectorType in SolverVisitorTest.java
kfriedberger
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the regression found by Philipp in CPAchecker. Z3 instantiates its bound variables reversed to the initial list of bound variables when building a quantified formula. We used them in the same order.
I also added some tests for this. (that should be extended at some point, but that can be done later as well)