Merge pull request #595 from splitio/polish-dev

polishing

Author: chillaq

client/src/main/java/io/split/client/SplitFactoryImpl.java

@@ -636,7 +636,7 @@ private static HttpClientBuilder setupProxy(HttpClientBuilder httpClientbuilder,
 
     private static HttpClientBuilder useLegacyProxyConfiguration(HttpClientBuilder httpClientbuilder, SplitClientConfig config) {
         HttpHost proxyHost = config.proxy();
-        httpClientbuilder = addProxyHost(httpClientbuilder, proxyHost);
+        addProxyHost(httpClientbuilder, proxyHost);
         if (config.proxyUsername() != null && config.proxyPassword() != null) {
             return addProxyBasicAuth(httpClientbuilder, proxyHost, config.proxyUsername(), config.proxyPassword());
         }
@@ -646,7 +646,7 @@ private static HttpClientBuilder useLegacyProxyConfiguration(HttpClientBuilder h
 
     private static HttpClientBuilder useProxyConfiguration(HttpClientBuilder httpClientbuilder, SplitClientConfig config) {
         HttpHost proxyHost = config.proxyConfiguration().getHost();
-        httpClientbuilder = addProxyHost(httpClientbuilder, proxyHost);
+        addProxyHost(httpClientbuilder, proxyHost);
         if (config.proxyConfiguration().getProxyCredentialsProvider() == null) {
             return httpClientbuilder;
         }
@@ -663,10 +663,9 @@ private static HttpClientBuilder useProxyConfiguration(HttpClientBuilder httpCli
         return httpClientbuilder;
     }
 
-    private static HttpClientBuilder addProxyHost(HttpClientBuilder httpClientbuilder, HttpHost proxyHost) {
+    private static void addProxyHost(HttpClientBuilder httpClientbuilder, HttpHost proxyHost) {
         DefaultProxyRoutePlanner routePlanner = new DefaultProxyRoutePlanner(proxyHost);
         httpClientbuilder.setRoutePlanner(routePlanner);
-        return httpClientbuilder;
     }
 
     private static HttpClientBuilder addProxyBasicAuth(HttpClientBuilder httpClientbuilder, HttpHost proxyHost, String userName, String password) {