Skip to content

Conversation

@jferrant
Copy link
Contributor

Wanted to open this so I could point to it for Hiro, sBTC, etc. folks to see so they can prep for its eventual release.

Jiloc and others added 30 commits September 17, 2025 14:42
merge develop -> aac-client-breaking
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
… into chore/merge-develop-to-aac-client-breaking
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jferrant Great idea!

What do you think about marking this as a draft instead? That way it’s clear we’re not ready to approve or merge it yet.

…ent-breaking

Chore/merge develop to aac client breaking
@fdefelici
Copy link
Contributor

Related issue: #6576

@fdefelici fdefelici moved this to Status: 💻 In Progress in Stacks Core Eng Oct 9, 2025
@fdefelici fdefelici linked an issue Oct 9, 2025 that may be closed by this pull request
jferrant and others added 10 commits October 10, 2025 14:51
…ent-breaking

Chore/merge develop to aac client breaking
… into chore/merge-develop-to-aac-client-breaking
…rrant/stacks-core into chore/merge-develop-to-aac-client-breaking
… into chore/merge-develop-to-aac-client-breaking
… into chore/merge-develop-to-aac-client-breaking
… into chore/merge-develop-to-aac-client-breaking
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…ent-breaking

Chore/merge develop to aac client breaking
@jacinta-stacks jacinta-stacks requested review from aaronb-stacks, federico-stacks and francesco-stacks and removed request for kantai October 22, 2025 18:25
jferrant and others added 5 commits October 22, 2025 11:37
… into chore/merge-develop-to-aac-client-breaking
… into chore/merge-develop-to-aac-client-breaking
Signed-off-by: Jacinta Ferrant <jacinta@stackslabs.com>
… into chore/merge-develop-to-aac-client-breaking
…ac-client-breaking

Chore/merge develop to aac client breaking
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 64.50867% with 921 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.56%. Comparing base (060b56e) to head (d94b35c).
⚠️ Report is 23 commits behind head on develop.

Files with missing lines Patch % Lines
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 49.05% 135 Missing ⚠️
clarity/src/vm/ast/parser/v2/mod.rs 9.85% 64 Missing ⚠️
...ty/src/vm/analysis/type_checker/v2_05/tests/mod.rs 63.47% 61 Missing ⚠️
clarity-types/src/errors/analysis.rs 62.66% 56 Missing ⚠️
clarity/src/vm/database/clarity_db.rs 37.83% 46 Missing ⚠️
clarity-types/src/errors/ast.rs 37.50% 40 Missing ⚠️
clarity/src/vm/database/structures.rs 53.48% 40 Missing ⚠️
...src/vm/analysis/type_checker/v2_05/tests/assets.rs 0.00% 39 Missing ⚠️
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 74.19% 32 Missing ⚠️
clarity/src/vm/ast/parser/v1.rs 48.27% 30 Missing ⚠️
... and 41 more

❌ Your project status has failed because the head coverage (64.56%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6537      +/-   ##
===========================================
- Coverage    66.23%   64.56%   -1.68%     
===========================================
  Files          574      574              
  Lines       354916   355097     +181     
===========================================
- Hits        235085   229266    -5819     
- Misses      119831   125831    +6000     
Files with missing lines Coverage Δ
clarity-types/src/lib.rs 100.00% <ø> (ø)
clarity-types/src/representations.rs 84.25% <ø> (ø)
clarity-types/src/tests/representations.rs 0.00% <ø> (ø)
clarity-types/src/tests/types/serialization.rs 86.14% <100.00%> (+29.05%) ⬆️
clarity/src/vm/analysis/arithmetic_checker/mod.rs 92.48% <ø> (ø)
clarity/src/vm/analysis/trait_checker/mod.rs 100.00% <100.00%> (ø)
clarity/src/vm/analysis/trait_checker/tests.rs 85.42% <ø> (ø)
...ity/src/vm/analysis/type_checker/v2_05/contexts.rs 98.24% <100.00%> (ø)
...src/vm/analysis/type_checker/v2_05/natives/maps.rs 95.32% <100.00%> (ø)
...rity/src/vm/analysis/type_checker/v2_1/contexts.rs 100.00% <100.00%> (ø)
... and 133 more

... and 232 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060b56e...d94b35c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change

Projects

Status: Status: 💻 In Progress

Development

Successfully merging this pull request may close these issues.

aac: align with partners and merge client-breaking branch AAC Initial Cleanup: Rename and document error structs and variants

6 participants